From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58259 invoked by alias); 19 Mar 2019 10:45:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105424 invoked by uid 89); 19 Mar 2019 10:45:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=Debian X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70072.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.72) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Mar 2019 10:45:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ipxcalJ4tA8WSjF7Qd1wZMv/J5GvLyQlRA5bluT9tcw=; b=b7Ft39rhvC34b4MWbgrkh8CUFWRCC+wWYqA4giTXRJgjPjpVFdONsJuxofChN14VZ+C/vHU4P8uUFV8YDpFiVuD015cmeLe0+IY1YCV3J7tJeSNr3NvnMiAa4PAeC9yAGHWX8FuM9c9hokszxo23yT4faeG0n46H9mn62qu40zk= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.13; Tue, 19 Mar 2019 10:45:10 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7%3]) with mapi id 15.20.1709.015; Tue, 19 Mar 2019 10:45:10 +0000 From: Alan Hayward To: GDB Patches CC: nd Subject: [PING][PATCH] Testsuite: Ensure pie is disabled on some tests Date: Tue, 19 Mar 2019 10:45:00 -0000 Message-ID: <1880525A-E1A5-4707-AEB2-F8DF1FA9BCBA@arm.com> References: <20190306102006.99150-1-alan.hayward@arm.com> In-Reply-To: <20190306102006.99150-1-alan.hayward@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00404.txt.bz2 Ping for this. > On 6 Mar 2019, at 10:20, Alan Hayward wrote: >=20 > Recent versions of Ubuntu and Debian default GCC to enable pie. >=20 > In dump.exp, pie will causes addresses to be out of range for IHEX. >=20 > In break-interp.exp, pie is explicitly set for some tests and assumed > to be disabled for the remainder. >=20 > Ensure pie is disabled for these tests when required. >=20 > gdb/testsuite/ChangeLog: >=20 > 2019-03-06 Alan Hayward >=20 > * gdb.base/break-interp.exp: Ensure pie is disabled. > * gdb.base/dump.exp: Likewise. > --- > gdb/testsuite/gdb.base/break-interp.exp | 4 ++++ > gdb/testsuite/gdb.base/dump.exp | 4 ++++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/gdb/testsuite/gdb.base/break-interp.exp b/gdb/testsuite/gdb.= base/break-interp.exp > index f85e8a650a..409c31e568 100644 > --- a/gdb/testsuite/gdb.base/break-interp.exp > +++ b/gdb/testsuite/gdb.base/break-interp.exp > @@ -627,6 +627,10 @@ foreach ldprelink {NO YES} { > if {$binpie !=3D "NO"} { > lappend opts {additional_flags=3D-fPIE} > lappend opts {ldflags=3D-pie} > + } else { > + # Recent Debian/Ubuntu defaults PIE enabled. Ensure it is disabled. > + lappend opts {additional_flags=3D-no-pie} > + lappend opts {ldflags=3D-no-pie} > } >=20 > set dir ${exec}.d > diff --git a/gdb/testsuite/gdb.base/dump.exp b/gdb/testsuite/gdb.base/dum= p.exp > index 44b0988b80..b2d7ef938a 100644 > --- a/gdb/testsuite/gdb.base/dump.exp > +++ b/gdb/testsuite/gdb.base/dump.exp > @@ -36,6 +36,10 @@ if {[istarget "spu*-*-*"]} then { > set is64bitonly "yes" > } >=20 > +# Ensure -pie is disabled as this breaks IHEX tests. > +# (PIE defaults to enabled on recent Debian/Ubuntu). > +lappend options "additional_flags=3D-no-pie" > + > if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab= le ${options}] !=3D "" } { > untested "failed to compile" > return -1 > --=20 > 2.17.2 (Apple Git-113) >=20