From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1015 invoked by alias); 17 Jan 2009 00:10:22 -0000 Received: (qmail 1007 invoked by uid 22791); 17 Jan 2009 00:10:21 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.23) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Jan 2009 00:09:44 +0000 Received: from kahikatea.snap.net.nz (unknown [123.255.31.213]) by viper.snap.net.nz (Postfix) with ESMTP id 29E392F4778; Sat, 17 Jan 2009 13:09:42 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 7BB2F8FC6D; Sat, 17 Jan 2009 13:09:31 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18801.8634.385465.267957@kahikatea.snap.net.nz> Date: Sat, 17 Jan 2009 00:10:00 -0000 To: Pedro Alves , gdb-patches@sourceware.org, ghost@cs.msu.su Subject: [PATCH]:annotations [was Re: [patch:MI] Observer for thread-changed] In-Reply-To: <18509.61742.680365.176465@kahikatea.snap.net.nz> References: <18509.7945.19078.399646@kahikatea.snap.net.nz> <200806100104.28694.pedro@codesourcery.com> <18509.57602.879804.675918@kahikatea.snap.net.nz> <200806100346.33522.pedro@codesourcery.com> <18509.61742.680365.176465@kahikatea.snap.net.nz> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00394.txt.bz2 On 10 Jun 2008 15:12:46 +1200 Nick Roberts writes: > > > If it goes at the end of do_captured_thread_select then I guess that > > > will be after any exceptions but, to me, putting the logic in > > > gdb_thread_select makes it clearer that the thread only gets reported > > > when there is no exception. > > > > I think it's clearer to put the observer close to where to switch is > > performed. Plus, if/when we remove libgdb and the wrapper, we have again > > to move the observer call... Not the end of the world, but might as well > > put it in the right place now, IMHO. Oh well, opinions :-) > > Seems reasonable. I'll do that. Ping. > -- > Nick http://www.inet.net.nz/~nickrob > > > --- thread.c 09 Jun 2008 21:06:46 +1200 1.71 > +++ thread.c 10 Jun 2008 15:11:13 +1200 > @@ -738,7 +738,6 @@ thread_command (char *tidstr, int from_t > return; > } > > - annotate_thread_changed (); > gdb_thread_select (uiout, tidstr, NULL); > } > > @@ -770,6 +769,8 @@ do_captured_thread_select (struct ui_out > error (_("Thread ID %d has terminated."), num); > > switch_to_thread (tp->ptid); > + observer_notify_thread_changed (); > + annotate_thread_changed (); > > ui_out_text (uiout, "[Switching to thread "); > ui_out_field_int (uiout, "new-thread-id", pid_to_thread_id (inferior_ptid)); > Vladimir has created his own notifications for thread changes now, so that part is no longer relevant but moving the call to annotate_thread_changed still is. -- Nick http://www.inet.net.nz/~nickrob 2009-01-17 Nick Roberts * thread.c (thread_command): Don't print an annotation if the thread change generate an exception. Index: thread.c =================================================================== RCS file: /cvs/src/src/gdb/thread.c,v retrieving revision 1.99 diff -p -u -p -r1.99 thread.c --- thread.c 3 Jan 2009 05:57:53 -0000 1.99 +++ thread.c 16 Jan 2009 23:58:47 -0000 @@ -1045,7 +1045,6 @@ thread_command (char *tidstr, int from_t return; } - annotate_thread_changed (); gdb_thread_select (uiout, tidstr, NULL); } @@ -1078,6 +1077,8 @@ do_captured_thread_select (struct ui_out switch_to_thread (tp->ptid); + annotate_thread_changed (); + ui_out_text (uiout, "[Switching to thread "); ui_out_field_int (uiout, "new-thread-id", pid_to_thread_id (inferior_ptid)); ui_out_text (uiout, " (");