From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99305 invoked by alias); 3 Oct 2016 17:48:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99290 invoked by uid 89); 3 Oct 2016 17:48:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Oct 2016 17:48:25 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by (Symantec Mail Security) with SMTP id A6.53.02551.5E992F75; Mon, 3 Oct 2016 19:48:22 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 3 Oct 2016 19:48:20 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.110.144] (192.75.88.130) by AMSPR07MB391.eurprd07.prod.outlook.com (10.242.22.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5; Mon, 3 Oct 2016 17:48:10 +0000 Subject: Re: [PATCH v3 2/2] Add test for user context selection sync To: Pedro Alves , Simon Marchi , References: <20160924201331.23605-1-simon.marchi@polymtl.ca> <20160924201331.23605-2-simon.marchi@polymtl.ca> <22ae2259-f47d-4ea0-53fc-510aa9b6f45c@redhat.com> CC: Antoine Tremblay From: Simon Marchi Message-ID: <187d9575-50f8-d877-7378-72cbc5c2da5e@ericsson.com> Date: Mon, 03 Oct 2016 17:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <22ae2259-f47d-4ea0-53fc-510aa9b6f45c@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CY1PR20CA0009.namprd20.prod.outlook.com (10.161.165.147) To AMSPR07MB391.eurprd07.prod.outlook.com (10.242.22.16) X-MS-Office365-Filtering-Correlation-Id: 5abf525c-4ef4-4610-3148-08d3ebb5719f X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB391;2:Yyirsz6PmIsTjhPMT48EOp5s0w6sFt+PanF9b2iub20FBriAxxSNg54Ym938ut9gA3jmJvZxK4m8mkIvUVIHbykn2B9lBnSNCpRtpx9aV0EEZKOxzvLL05WavSxjN0gkg1GrDn5lTqRl0o40X1G0lfuPAeWw4NRQHtWFTaU/T60oYygG594S5BzvUty1J928;3:EPY9KBh0TGM77dr4ojqQHURJfgijxQwXykuGn7mIYjjERHZWpkO2oUv541lWb77JiRZu/nb6sTV6OuId9vCANF6MimL1gUdYIHMybMsBOYKnR8UvMKhdAWiJBJv3VmYa;25:zDgGj+dhofp+PYoY1PHo/aND+ksEqQVGngXWOZp9m2INoIGqkMyWb5GjT4s2VFbFubxruYXPKM9CWu4ps+qWyrtQktfm9AImYrZaywZYhOM+ZM2HGPGxc56BryaC5sw3Esm962Z/7yS6Jra1Z1xA0RbYb5PVaMNy1D5Xn2EChsOJTfo7SXK8DPIv22NolSuL20dMUSvXpax/Q3KjJtZKQjJANN1b+7Bx/mrD3XxIDC8dpb7227/mZxG3im9d6gkKTWsBYbgzqg6++5qKzICSt19z/GY1LA/MLZlnkupCxXbhwS6qRlH7Pv7vNoX+5hyrXRNj9HtwZfGoxcgOGCenUE5j8JqV0ElpClPyy0ARLrzktjztV4R9p67BpphFD873TTBFuAFTlBiCvxhlkucObmQnvuC7icqWFoNXjclczeA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB391; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB391;31:GDIKyDLNmWNe8Ima41UEz8MGOOuj7ib4ijeHOmO5aeLU/BdUqwjZHUjM884ReORw9/hAEsKjvfNodiQVlT0AtNjn68ntvuSRNFTwRocT2MWcWgHRKCtKKTaUXleTdURUxc1C9vJcI6tNsFlgktBhMzUgPzO4khmix4JBiSwREPI8pJS/Ze3JUIelv5EnxBRQdgz2x1eAaezpszevLvhe9W245VsZz9iNb/YMwpHVt+s=;20:VX1Un5sROr4R/RM5Im/CoAM5tNbJupUdSqd6GJaAwQD3a2lg45X+XVeApzWRuGw3GnaTURQuJLwniH0SSa3ZRyjzrUDowiFYMgWg0KCUNMT3cNqC0ChuFhCE3tInqVy7HJfhDj0X2r6BFQ4v65CbuxSgMYjalDBTH7CdG2h1MvjBwh87W2u+EXlauCaJPtQkG6aXMBwy+LkYc+I/BlYhv09zSkkorCLlj5Rl4x3Ay5bfwEd0J2wcLql7cXHGIymybdaN2VUP1PI46yU0RlU3/vy8kNn/sRo6+RluU6olRBCAGo8l8rReaJGIzcdN/nsn38S2cJD8oMftNo/WND3vLg73EfS72W+GobN+XT+CFzofGaD/kiAQ9PFYbjMMr28dOB+c2M9w0soJrZgc1IZyKVZUrkNJ30KjLiJ4pG8Y0VDNIKfqaESC/H/YRpb6Jnn8dtukb30TOI40ZTvSAaLGAxAPjMP8V5874HAlvgvGcOR8xpPdduQYHde1Ephtu61D X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:AMSPR07MB391;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB391; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB391;4:DsdQ7uv1VIxx2pK8F6xkN6ov43E+VVtrWlOePkX1SgS93SQFpJkZwv2b9vxnAtERlXUhkRihGoEeJBmXvB5YmbMihHnZVATg+YcuvugKRJDZjQ0PDQD089PR3Tye64Gwaw/b1KCyj2I18jaXcfOnDR4vLspa7Aq/uLAX7JwL0oBbvS3mxbMhJCBFXNGBh008nw2/be+ZXe7TGr0sHlyIUZAoVhQ11iBkWW+BfdGxHwRrKczaSCd2ZG6F4KjZjk+pTyQJCd6kgjt141H8/RN1ne/UK8cTw3z9YUF8vbwXeIrpacy+meMAECEB2I1sSOwxHkXmDtSgIvw67y4ShwR4/+NQWdgmFT3bjAXyg+mcx8OvLr4Ox3wGuuPKa9QgLUzrrDXuI5gLb9Yh9Oul7t1R3IpSDyW14HjI1JpsKFstjA3O6Q6YWs305IjIPD/WTQn9 X-Forefront-PRVS: 008421A8FF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(24454002)(199003)(377424004)(189002)(377454003)(92566002)(33646002)(7736002)(7846002)(65826007)(107886002)(305945005)(5001770100001)(97736004)(4001350100001)(106356001)(23746002)(105586002)(230700001)(4326007)(2906002)(42186005)(64126003)(31686004)(77096005)(4001430100002)(5660300001)(54356999)(6116002)(47776003)(65956001)(65806001)(76176999)(31696002)(68736007)(3846002)(50466002)(81166006)(81156014)(2950100002)(101416001)(83506001)(6666003)(36756003)(50986999)(8676002)(189998001)(66066001)(86362001)(586003);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB391;H:[142.133.110.144];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AMSPR07MB391;23:LeCzpJHzC6GJm4ujB4k3GAsPf/ugtvtL2GJVvp?= =?Windows-1252?Q?97Tct6hwl5DpYvFkyX0KSbUZthjYqjb+MleHynRg80eMoVMErOj9hqW1?= =?Windows-1252?Q?iO6rm8G3pCAnoqWsK20wo7Se3k8Nu5mfLWYVXKjy7uv9tb/OO/UtPQd7?= =?Windows-1252?Q?AU6ct8knN/6uIpaOVud5pFlppgpedgqeVQRCvJVxy4GOKClOOtUAVSE3?= =?Windows-1252?Q?COkDWqNKCufeUiW+VhCB+j9ro2O+lOGM9OW+1x8OEoueN9LDy5VVPxXb?= =?Windows-1252?Q?UhUha1PfooWM1/pnZDWYqGd4a519rMzCNxwnhW3MFextat3LwxzQET9G?= =?Windows-1252?Q?AaL15/6wcE/Rf/VvOtnizWLwOSiBcfXIX3mLbFo5BzOkD2R+cn2/dUS9?= =?Windows-1252?Q?Cwcy3t8yfXOk0DB7kUhkwulsqhBlDZn49v4/WZPCp0VlDzFnE4h8ioa2?= =?Windows-1252?Q?u6BE659XX+UIJYbnK/+usM+Dbj6Nfh9AIIWLiLzMG3FS9+1997a/dy+9?= =?Windows-1252?Q?lG08OMtEOeWx2hNMK+GTPn/VFQNxQLLidVenf9NCOBPYHVebbBQBPWxA?= =?Windows-1252?Q?m1wacmu9hbG4hdJtgUvxPrf3fomo+uSzLZ43KFQQcxT0Lp6HSa64lSw0?= =?Windows-1252?Q?w5yPPP3meWj6EMqKpOfLhghkn7ywtNccES9thjYwZavOL8FE/NRARHHt?= =?Windows-1252?Q?R1l24yXkqr74ADa6t+BZ+UIhyPU1abqFr2lB6Xu3GNPD4bJKx4Fvj2Fx?= =?Windows-1252?Q?x0ueIl25QR/2TURuaunpQgrA3uq+MvOwSq+Byk8pGmRdOMqM+ICjQhe/?= =?Windows-1252?Q?HTphu5togknFkuzZBrxZd+ICq5Ei1smsyjvw7t+G8IPl3pmkezaTh6Wv?= =?Windows-1252?Q?mQNjaOpqJq6vmdrwPRqgGrd71yZTnom1boVWA4qsLalvtrm404yT5Ibq?= =?Windows-1252?Q?b4ZN8je5nFQsYw2a/9I4EL4QiFueZzRmnVq1QcMttON5dpeKhPIbWJVu?= =?Windows-1252?Q?dv1fgmLR00rQ81pxsx4z585iswQ8TmTs6+7nCpFTsKPoHmN61GkVTwPh?= =?Windows-1252?Q?7R3/EoQ2B3I/34LPo1Y6qTs5ios0byZX+q3AIyHeiNSS/LgNnJ/KVo5G?= =?Windows-1252?Q?u+7TtDYgEp4Y+dOv7BR8pLplg4UFrU6BNehnQ3U3gBP57iIXAv72/smV?= =?Windows-1252?Q?6EqFbjAwbcWs/qU120REUjZ1jXsYJxxC1oza/vJ7q2jTTN0ZhxDrPC+/?= =?Windows-1252?Q?PqRLyfoLF6gCc+cBuRA0AcSc4pnN+KgOMdeTtTs/MsywKWvZuGA0yRha?= =?Windows-1252?Q?HdUcbJ96rR5BO0MvwCMyxgKXCnGNlh3yHo/PeFgSpsGVAkzNbNz0J2tN?= =?Windows-1252?Q?MHu8tXU3gSerdefNWSgTWJBmyD6xlEDLpSwGqoZqX8fUGY6TpekFXJ5O?= =?Windows-1252?Q?zYLeGXk2boo4r6i/zmoM2ZbgAmwJ8d0oDysGNfaA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB391;6:kyZWCqoDB6lZW6O9cvMkD0WeIVkrkoay5Iwo4/wa24P/2EZUQBpxJORgP1gPjJw9qLSr+L7VyV6Y8u0C0ISpvN4Lw3MWw8EmCSu+dsxdPWm+GBCUfcgbI7HQAgbxGvYunUJm6hkez6c/32RQZpUG5RP0snaL2OrpMT0ma5jpcbqT0Z1xDiu2CcJbn9igyr2DDpdNA1aeRXPVBZ6Zc3MXrCl+qty7VQV+Pux8K7UTK/vKNDX8Eu2Niluw/RPmSmUYBoaA7j9osmJV2nt90cop4q3qPtzq2zaURX0Sp2bdUpw=;5:kS74UsJmL+3ziOVyPc1TPUjKhtKi8C+eckL+7pg8S/EcT7z76jLM/qNwhU1tswBmPodL4ycgnlzx3shN3h+qcQ11NlAGlv9fTEI8PJYQaeRPBZs+vPQZ5LoD6+r/VYBy0sfAD5Vv1U6QH0/w1pl0qA==;24:ISUpJzf/f6T7xcAFNcZZ8OA+zOWk9nLoCvD0jpy2MN7iU6WIBOol5/TBuE4SilcGSSQrxfdWFEqTi0Odeoj8/BBE3mrCpKmMp57RZAMgDis=;7:9Jf54pgSzB+hAFKZS7XDGW/etLrkUL96OzZxe9mZKMrAcnLfDVekwqM/3TZk0/P73touVnbS29S5qAe5KwDdjxnBOoXFyAnQpUX9ztAaacrOUxYzcO2D/zX1bfOTdHpVnmG4UTYmPrl+jhEyywv3HL3fF/0PdF9k2MIScswdqaPWAGefku2CVlVXFIp2HyZzxq9B0elvjOTdjDRdV1GyRGTNdRTwmqlFgAIrMOjyRk0xmywSJ7OT4kh4a3cuzy6BZWiOuT9zkiJOVCOlDArwp0qaBgoR9auztfMiYVQiPg1U+FbWRhngtRjI+6VV1hsO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2016 17:48:10.1135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB391 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00020.txt.bz2 On 16-10-03 01:10 PM, Pedro Alves wrote: > On 09/24/2016 09:13 PM, Simon Marchi wrote: > >> +set main_break_line [gdb_get_line_number "main break line"] >> +set thread_loop_line [gdb_get_line_number "thread loop line"] >> +set thread_caller_line [gdb_get_line_number "thread caller line"] >> + >> +# Call PROCNAME with the given arguments, inside a with_test_prefix $procname >> +# block. >> + >> +proc with_test_prefix_procname { procname args } { >> + with_test_prefix $procname { >> + # Note: this syntax requires TCL 8.5, if we need to support 8.4, >> + # we'll need to find an alternative. >> + $procname {*}$args >> + } >> +} > > An alternative (not talking about TCL 8.5 here), would be to > go the gdb_caching_proc way. That is, something like: > > proc prefixed_proc {name body} { > ... > } > > .. and then define the procs that you want to prefix with > prefixed_proc instead of proc. Interesting, I hadn't thought of that. > But either way is fine with me. > > I mildly dislike using the proc names as prefix strings as it feels > like implementation details leaking, but as long as the proc names are > clear enough, I won't really complain about it. Who knows, I may even > grow to like it. :-) I agree about the principle. While developing though, I found it was very useful since it allowed to jump directly to the right procedure. >> + # When using mi_expect_stop, we don't expect a prompt after the *stopped >> + # event, since the blocking commands are done from the CLI. Seting async to >> + # 1 makes it not expect the prompt. >> + set async 1 > > "Setting". Fixed. Thanks, Simon