From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1491 invoked by alias); 26 Jun 2008 03:21:06 -0000 Received: (qmail 1482 invoked by uid 22791); 26 Jun 2008 03:21:05 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jun 2008 03:20:22 +0000 Received: from kahikatea.snap.net.nz (222.30.255.123.static.snap.net.nz [123.255.30.222]) by viper.snap.net.nz (Postfix) with ESMTP id F183D3DA5B8; Thu, 26 Jun 2008 15:20:18 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 632EA8FC6D; Thu, 26 Jun 2008 15:20:16 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18531.2798.547630.806116@kahikatea.snap.net.nz> Date: Thu, 26 Jun 2008 13:33:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [MI/RFC] Emit ^running via observer. In-Reply-To: <200806251835.08864.vladimir@codesourcery.com> References: <200806140108.24047.vladimir@codesourcery.com> <18523.6804.971901.408892@kahikatea.snap.net.nz> <200806251835.08864.vladimir@codesourcery.com> X-Mailer: VM 7.19 under Emacs 22.2.50.3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00465.txt.bz2 > I've checked in the following, which differs from original by extra test > strictness. Thanks. > Further, I've converted mi-async.exp to use the helper > functions. Nick, as it stands now it does not seem that mi-async.exp tests > async behaviour at all -- it merely changes that we get ^running for CLI > commands, and we get that in both sync and async mode. Do you think it > worthwhile to rename the test or move its content somewhere else? The tests appear to fail now. However, there is still a difference in output for sync and async behaviour and this is what the test is for. ASYNC: (gdb) r &"r\n" ~"Starting program: /home/nickrob/myprog \n" =thread-created,id="1" ^running *running,thread-id="all" (gdb) *stopped,reason="breakpoint-hit",disp="keep",bkptno="1",thread-id="1",frame={addr="0x08048706",func="main",args=[{name="argc",value="1"},{name="argv",value="0xbfaf2db4"}],file="myprog.c",fullname="/home/nickrob/myprog.c",line="146"} SYNC: r &"r\n" ~"Starting program: /home/nickrob/myprog \n" =thread-created,id="1" ^running *running,thread-id="all" (gdb) ~"\n" ~"Breakpoint 1, main (argc=1, argv=0xbf961424) at myprog.c:146\n" ~"146\tmain (int argc, char **argv) {\n" *stopped (gdb) i.e no reason, frame, file, etc fields. It's important for the console in a frontend that the CLI command generates the same MI output as the corresponding MI command. The async version now seems to be missing a final "(gdb) \n". Maybe that's why the tests are failing. -- Nick http://www.inet.net.nz/~nickrob