Re: [PATCH] Fix displaced stepping watchpoint check order

Luis Machado via Gdb-patches
2021-07-30T01:32:58Z

On 7/29/21 9:59 PM, Simon Marchi wrote:
>
>
> On 2021-07-29 4:17 p.m., Luis Machado wrote:
>> Hi,
>>
>> On 7/29/21 4:36 PM, Simon Marchi wrote:
>>> I think this is ok, but in all honestly I don't completely understand
>>> how the interaction between watchpoints and displaced stepping is
>>> expected to work.
>>
>> Let me try to clarify. When we attempt to execute an instruction in the scratch space (displaced stepping), we may potentially trigger a hardware watchpoint.
>>
>> For AArch64, hardware watchpoints are non-steppable, so that means GDB will need to step over that hardware watchpoint so the instruction's execution completes (if there is no hardware watchpoint trigger, the instruction gets executed just fine).
>
> What does "need to step over that hardware watchpoint" means,
> concretely? After the watchpoint has triggered, are the side effects of
> the instruction committed to memory and registers? Or are we in a state
> as if the instruction didn't complete? How is that step over done?

No side effects of the instruction are committed in this case. Memory
and registers will have their old values as if the instruction didn't
execute.

From reading the code, most architectures have non-steppable hardware
watchpoints. GDB just disables the hardware watchpoints, single-steps
past that instruction and then enables the hardware watchpoints again.

GDB just disables all hardware watchpoints for the sake of simplicity.
You can see this logic in infrun.c:handle_signal_stop, around this comment:

/* If necessary, step over this watchpoint. We'll be back to display
it in a moment. */
if (stopped_by_watchpoint
&& (target_have_steppable_watchpoint ()
|| gdbarch_have_nonsteppable_watchpoint (gdbarch)))

It is actually best to disable all hardware watchpoints. If we end up
disabling just one hardware watchpoint, and then we happen to have
another hardware watchpoint that is active and also getting triggered,
we might be stuck in an endless loop as well.

>
>>>
>>> Just some nits:
>>>
>>> On 2021-06-08 11:42 a.m., Luis Machado via Gdb-patches wrote:
>>>> When checking the stopped data address, I noticed, under some circumstances,
>>>> that the instruction at PC wasn't the expected one. This happens because the
>>>> displaced stepping machinery restores the buffer before checking if the
>>>> instruction executed successfully, which in turn calls the watchpoint check.
>>>>
>>>> I guess this was never noticed because stopped data address checks usually
>>>> don't need to fetch the instruction at PC, but AArch64 needs to do it from
>>>> now on.
>>>
>>> Can you clarify what you mean by "from now on"? Can you indicate what
>>> change you are referring to?
>>>
>>
>> From the following change (https://sourceware.org/pipermail/gdb-patches/2021-July/181095.html) onwards, we need to look at the load/store instruction to figure out the memory access size so we can reliably tell if a hardware watchpoint has triggered. This is due to how AArch64's spec defines how to provide a stopped data address, and the valid ranges.
>
> Ok, but that patch you linked isn't merged yet? So it sounds strange to
> say "from now on", it sounds like there's a dependency between the two

Absolutely. There is a dependency. My plan is to merge this fix first,
and then merge the AArch64 hardware watchpoint detection fixes. I just
didn't group those together, but that's the right order. I'll make sure
to point out the dependency in the other patch.

> patches. Let's say the current patch is merged before the other one,
> maybe it should say "but AArch64 will need to do it it an upcoming
> patch", and then you can given the link.
>
>> With the old code, if we try to fetch the instruction at PC, we will get a bogus value that is not the real instruction that caused the hardware watchpoint trigger. Hence why the patch moves the call to displaced_step_instruction_executed_successfully (...) up and before we restore the displaced stepping buffer.
>>
>> If a hardware watchpoint trigger takes place and GDB doesn't recognize it, then displaced_step_instruction_executed_successfully (...) will return true and GDB will move on and will attempt to execute the same instruction again, only to be halted due to the same hardware watchpoint trigger that it can't detect. So GDB gets into an infinite loop.
>>
>> More generally, if we ever fail to acknowledge a hardware watchpoint trigger on an architecture with non-steppable watchpoints and displaced stepping support, we will run into this infinite loop (as far as I can tell).
>>
>> Does that make sense?
>
> Yes, this help. Please feel free to include in the commit message any
> additional detail that you gave here, since it might help somebody else
> in the future.

I'll make the commit message more detailed.

>
> The code change is fine, so once you send a revised version it should go
> fairly quickly. Sorry for the delay.

No worries. Thanks for the feedback!

>
> Thanks!
>
> Simon
>