From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15366 invoked by alias); 6 Jun 2008 03:00:33 -0000 Received: (qmail 15357 invoked by uid 22791); 6 Jun 2008 03:00:33 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Jun 2008 03:00:05 +0000 Received: from kahikatea.snap.net.nz (246.61.255.123.dynamic.snap.net.nz [123.255.61.246]) by viper.snap.net.nz (Postfix) with ESMTP id B846B3DA6B6; Fri, 6 Jun 2008 15:00:02 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id D5FA88FC6D; Fri, 6 Jun 2008 14:59:42 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <18504.43037.355720.133165@kahikatea.snap.net.nz> Date: Fri, 06 Jun 2008 03:00:00 -0000 To: Pedro Alves Cc: gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [PATCH] Another annotation for threads In-Reply-To: <200806060338.51693.pedro@codesourcery.com> References: <18483.36546.101715.670386@kahikatea.snap.net.nz> <20080605212615.GA6969@caradoc.them.org> <18504.35208.397231.7949@kahikatea.snap.net.nz> <200806060338.51693.pedro@codesourcery.com> X-Mailer: VM 7.19 under Emacs 22.2.50.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00101.txt.bz2 > 2008-05-21 =A0Nick Roberts =A0 >=20 > =A0=A0=A0=A0=A0=A0=A0=A0* annotate.c (annotate_thread_changed): New func= tion. > =A0=A0=A0=A0=A0=A0=A0=A0* thread.c (thread_command) : Use it. > =A0=A0=A0=A0=A0=A0=A0=A0* infrun.c (normal_stop): Use it. >=20 > This broke the build, as the annotate_thread_changed function isn't > declared anywhere. >=20 > I checked the attached in, as obvious. Yes, sorry. I have several changes in that directory and I missed that fil= e in the patch that I posted. > Out of curiosity, was there a reason you committed every file as > individual commits? It's customary to do a patch per commit > (not that is matter that much with CVS, but still nice to be > able to correlate by date, and to look at gdb-cvs). It's the way VC works in Emacs. I could use pcl-cvs but I've not really got used to it. Each file is committed individually but the changeset is given in the ChangeLog, although multiple ChangeLogs are needed across directories as is the case here. It would be nice to move GDB to a modern version control system where patch= es are really committed as changesets. Systems such as GIT allow local branch= es also which would help to keep local changes separate too. It's also easier to try multiple file patches out from the mailing list and revert them, etc, etc. For now, anyway, I'll try to use pcl-cvs to keep the traffic down on gdb-cv= s. --=20 Nick http://www.inet.net.nz/~nick= rob