From: Nick Roberts <nickrob@snap.net.nz>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, ghost@cs.msu.su
Subject: Re: [PATCH:MI] Use observers for breakpoints
Date: Fri, 06 Jun 2008 01:19:00 -0000 [thread overview]
Message-ID: <18504.36980.288830.447468@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20080605220528.GB3602@adacore.com>
> I would still prefer it if you passed the breakpoint rather than
> the breakpoint number. I'd rather not have to change the interface
> later if the breakpoint ended up being needed.
Sure, it's quite easy to do.
> > breakpoint_create_event
> > breakpoint_modify_event
> > breakpoint_delete_event
> >
> > I don't know if there's much to be gained in differentiating between
> > creating and modifying a breakpoint but it would certainly make sense
> > to have two observers, breakpoints_changed and breakpoints_deleted, say.
>
> We can indeed start with 2 for now.
OK, I'll do that.
I'll submit another patch but it won't be anytime in the near future because I
have to look more carefully at the output of each type of breakpoint command.
As it breaks existing behaviour, the MI level would need to be bumped. It
would make sense to do this at the same time as other similar pending changes,
e.g., no-stop mode, argument parsing etc
Perhaps we could aim for a release in which to do this, e.g. 7.0, in about
a year's time?
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2008-06-06 1:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 2:46 Nick Roberts
2008-06-01 3:21 ` Eli Zaretskii
2008-06-01 3:30 ` Nick Roberts
2008-06-03 5:08 ` Joel Brobecker
2008-06-03 22:48 ` Nick Roberts
2008-06-05 22:05 ` Joel Brobecker
2008-06-06 1:19 ` Nick Roberts [this message]
2008-06-04 7:31 ` Vladimir Prus
2008-06-04 8:34 ` Nick Roberts
2008-06-06 5:08 ` Vladimir Prus
2008-06-09 10:47 ` Nick Roberts
2008-06-09 16:53 ` Vladimir Prus
2008-06-10 2:46 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18504.36980.288830.447468@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ghost@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox