From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128980 invoked by alias); 12 Jun 2018 15:09:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128970 invoked by uid 89); 12 Jun 2018 15:09:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=staff X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0086.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jun 2018 15:09:53 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2549.eurprd08.prod.outlook.com (10.172.251.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.18; Tue, 12 Jun 2018 15:09:49 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d984:bdee:1856:c64]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d984:bdee:1856:c64%7]) with mapi id 15.20.0841.019; Tue, 12 Jun 2018 15:09:49 +0000 From: Alan Hayward To: Pedro Alves CC: Simon Marchi , GDB Patches , Simon Marchi , nd Subject: Re: [PATCH v2 02/10] Add Aarch64 SVE Linux headers Date: Tue, 12 Jun 2018 15:09:00 -0000 Message-ID: <1849A709-8B9D-4BD3-804D-C8697AB7430B@arm.com> References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-3-alan.hayward@arm.com> <9FBBFBF2-9363-49AA-8BC3-20E4E0AFBFED@arm.com> <5862fa9c22cc48d86256686e74d60f20@polymtl.ca> <82743c0795488492486076685b9f8828@polymtl.ca> <8f6d2b87-707a-3e34-325c-ed9338e9c1f6@redhat.com> In-Reply-To: <8f6d2b87-707a-3e34-325c-ed9338e9c1f6@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: DB6PR0802MB2549: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(244540007438412); x-ms-exchange-senderadcheck: 1 x-forefront-prvs: 07013D7479 received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <000115B3910E674F8F8A52C6248EC1B9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 17fa616c-351f-4598-3e4e-08d5d0768afd X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17fa616c-351f-4598-3e4e-08d5d0768afd X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2018 15:09:49.8713 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2549 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00312.txt.bz2 DQoNCj4gT24gMTIgSnVuIDIwMTgsIGF0IDE1OjQzLCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMDYvMTIvMjAx OCAwMzozNyBQTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4gDQo+PiANCj4+ PiBPbiA4IEp1biAyMDE4LCBhdCAxNjoyMywgU2ltb24gTWFyY2hpIDxzaW1v bi5tYXJjaGlAcG9seW10bC5jYT4gd3JvdGU6DQo+Pj4gDQo+Pj4gT24gMjAx OC0wNi0wOCAxMDozNywgU2ltb24gTWFyY2hpIHdyb3RlOg0KPj4+PiBUaGUg Y29kZSBsb29rcyBnb29kIHRvIG1lLCB0aGFua3MuICBJIGFtIHN0aWxsIHVu c3VyZSBhYm91dCB0aGUNCj4+Pj4gbGljZW5zaW5nIHNpZGUgb2YgaXQsIGxl dCBtZSBhc2sgdGhlIEZTRiBwZW9wbGUgYWJvdXQgaXQsIEknbGwgY29tZQ0K Pj4+PiBiYWNrIHRvIHlvdSB3aGVuIGl0J3MgZG9uZS4gIEkgaG9wZSBpdCB3 b24ndCB0YWtlIHRvbyBsb25nIQ0KPj4+IA0KPj4+IEhpIEFsYW4sDQo+Pj4g DQo+Pj4gQWZ0ZXIgZGlzY3Vzc2lvbiB3aXRoIG90aGVyIG1haW50YWluZXJz LCBpdCB3YXMgc3VnZ2VzdGVkIHRvIGF2b2lkIGludm9sdmluZyB0aGUgbGVn YWwgc3RhZmYgaWYgd2Ugd2FudCB0byByZXNvbHZlIHRoaXMgYW55dGltZSBz b29uLg0KPj4+IA0KPj4+IFNpbmNlIEFSTSBhbHJlYWR5IGhvbGRzIHRoZSBj b3B5cmlnaHQgdG8gdGhlc2UgaGVhZGVyIGZpbGVzIGFueXdheSAodGhleSB3 ZXJlIGFsbCB3cml0dGVuIGJ5IEFSTSBwZW9wbGUpLCB5b3UgbWF5IGJlIGFi bGUgdG8gc3VibWl0IHRoYXQgY29kZSBhcyByZWd1bGFyIEZTRi1hc3NpZ25l ZCBjb2RlLCB3aXRob3V0IGNoYW5naW5nIHRoZSBzdGF0dXMgb2YgdGhlIGtl cm5lbCBjb3B5LiAgQnV0IG5vYm9keSBoZXJlIGlzIGEgbGF3eWVyLCBzbyBu b2JvZHkgd2FudHMgdG8gc2F5IGZvciBzdXJlIDopLg0KPj4+IA0KPj4+IE1h eWJlIGl0J3Mgb2sgYWZ0ZXIgYWxsIGlmIHdlIGRvbid0IGluY2x1ZGUgdGhl c2UgaGVhZGVycyAoYXQgbGVhc3QgZm9yIG5vdyksIGFuZCByZXF1aXJlIHRo YXQgR0RCIGZvciBuYXRpdmUgQUFyY2g2NCBpcyBidWlsdCBhZ2FpbnN0IHRo ZSBoZWFkZXJzIG9mIGEgPj0gNC4xNSBrZXJuZWw/ICBUaGV5IGNhbiBhbHdh eXMgYmUgaW5jbHVkZWQgbGF0ZXIsIGJ1dCBpdCB3b3VsZCBhdm9pZCBkZWxh eWluZyB0aGUgaW5jbHVzaW9uIG9mIHRoZSBmZWF0dXJlLCBzaW5jZSB5b3Ug d2FudCB0byBoYXZlIGl0IGJlZm9yZSB3ZSBicmFuY2ggOC4yLg0KPj4+IA0K Pj4gDQo+PiBTb3JyeSwgSSBkaWQgbWlzcyB0aGlzIG9uZSAoSSB0aGluayBJ IHNlbnQgbXkgcmVwbHkgdG8gdGhlIHByZXZpb3VzDQo+PiBvbmUgbW9yZSBv ciBsZXNzIHRoZSBzYW1lIHRpbWUgeW91IHNlbnQgdGhpcykuDQo+PiANCj4+ IElmIEkgY29tbWl0IHRoaXMsIA0KPiANCj4gV2hhdCdzICJ0aGlzIiA/ICAN Cg0KU2hvdWxkIGhhdmUgc2FpZCDigJxpZiBJIGNvbW1pdCA0LzEwIHdpdGhv dXQgMi8xMCBpdOKAmXMgZ29pbmcgdG8gY2F1c2UNCmJ1aWxkYm90IHRvIGJy ZWFrIiANCg0KPiANCj4gSG93IGFib3V0IHdlIGFkZCBhIGNvbmZpZ3VyZSBj aGVjayB0byBjaGVjayBpZiB0aGUgc3lzdGVtIGhlYWRlcnMgc3VwcG9ydA0K PiB0aGUgbmVlZGVkIFNWRSBiaXRzLCBhbmQgZ3VhcmQgdGhlIG5hdGl2ZSBn ZGIgU1ZFIGJpdHMgd2l0aA0KPiBIQVZFX0FBUkNINjRfU1ZFIG9yIHNvbWV0 aGluZyBsaWtlIHRoYXQ/DQo+IA0KDQpFeGNlbGxlbnQgaWRlYS4gSSBjYW4g aGF2ZSBhIGxvb2sgYXQgZG9pbmcgdGhpcyAtIHNob3VsZCBiZSBmYWlybHkg cXVpY2sgdG8gZG8uDQoNCkluIHRoZSBtZWFudGltZSwgbGV0cyBrZWVwIHRo ZSBvdGhlciBkaXNjdXNzaW9uIGdvaW5nLg0KDQoNCkFsYW4uDQoNCg== >From gdb-patches-return-148170-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jun 12 15:11:30 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 24027 invoked by alias); 12 Jun 2018 15:11:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 24016 invoked by uid 89); 12 Jun 2018 15:11:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jun 2018 15:11:28 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0E71401EF24; Tue, 12 Jun 2018 15:11:26 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0433111CB8E; Tue, 12 Jun 2018 15:11:25 +0000 (UTC) Subject: Re: [PATCH v2 02/10] Add Aarch64 SVE Linux headers To: Simon Marchi References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-3-alan.hayward@arm.com> <9FBBFBF2-9363-49AA-8BC3-20E4E0AFBFED@arm.com> <5862fa9c22cc48d86256686e74d60f20@polymtl.ca> <82743c0795488492486076685b9f8828@polymtl.ca> <8f6d2b87-707a-3e34-325c-ed9338e9c1f6@redhat.com> <104a9ac067b435bd80a0b19fc638d0d0@polymtl.ca> Cc: Alan Hayward , GDB Patches , Simon Marchi , nd From: Pedro Alves Message-ID: <0f4bd1b7-897f-b42a-3067-2397a1b4c58c@redhat.com> Date: Tue, 12 Jun 2018 15:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <104a9ac067b435bd80a0b19fc638d0d0@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-06/txt/msg00313.txt.bz2 Content-length: 1487 On 06/12/2018 04:06 PM, Simon Marchi wrote: > On 2018-06-12 10:43, Pedro Alves wrote: >> What's "this" ? > > From what I understand, "this" is the suggestion I made in my previous mail, require the user to build against the headers of a recent kernel (that provide the SVE macros), and not provide a stop-gap copy in the GDB tree.  It would break the buildbot, because they have an old kernel that doesn't provide the SVE macros the GDB code uses (e.g. SVE_PT_REGS_OFFSET). OK, that was not what I had suggested the other day (which was to detect SVE support at configure time), so I got confused. > >> How about we add a configure check to check if the system headers support >> the needed SVE bits, and guard the native gdb SVE bits with >> HAVE_AARCH64_SVE or something like that? > > I think that would be a good compromise.  By default, building on a machine with an older kernel would exclude SVE support.  But it would be possible to add it by pointing to the headers of a recent kernel.  So when building on a machine with an older kernel... > > - ... without any special flags, you don't get SVE support. > - ... with just --enable-sve, you get a configure error. > - ... with --enable-sve and CFLAGS/CXXFLAGS pointing to headers of a kernel w/ SVE macros, you get SVE support. > > Does that make sense? Yes. Not sure an --enable-sve switch is necessary (compared to just having headers vs not having headers), but I'd be fine with having one. Thanks, Pedro Alves