From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24390 invoked by alias); 11 May 2008 14:10:08 -0000 Received: (qmail 24378 invoked by uid 22791); 11 May 2008 14:10:07 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 11 May 2008 14:09:40 +0000 Received: from kahikatea.snap.net.nz (204.63.255.123.dynamic.snap.net.nz [123.255.63.204]) by viper.snap.net.nz (Postfix) with ESMTP id AD2063D9CD8; Mon, 12 May 2008 02:09:36 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 6C40D8FC6D; Mon, 12 May 2008 02:09:31 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18470.65050.501601.790988@kahikatea.snap.net.nz> Date: Sun, 11 May 2008 15:52:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Report the main thread. In-Reply-To: References: <18469.39280.284106.858072@kahikatea.snap.net.nz> <18470.7609.400548.29643@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.2.50.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00352.txt.bz2 > > Yes, you're right. I didn't notice that the observer in > > add_thread_with_info was removed at the same time this one was added. > > > > I just want threads other than the main thread to be reported, as used to > > be the case. > > Assuming that makes sense for annotations, I think your observer is in > position to decide which threads to report, and which not? Currently the new_thread observer only declares struct thread_info and not it's members so I can't identify the thread number in annotate.c > > That way I can create a threads buffer and display the thread > > number when there is more than one thread. > > Cannot you just suppress display of thread list if there's just one > thread reported, on UI side? Yes, I could count the new-thread annotations and and only trigger things when there is more than one thread. It's simpler if I don't have to and I'm just baffled why I need to go through these hoops for a small stop gap change that no-one else is interested in using. The only requirement I can see on such a patch is that it doesn't affect anybody else's use of Gdb, and I think my original patch filled that requirement. -- Nick http://www.inet.net.nz/~nickrob