Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Adam Nemet <anemet@caviumnetworks.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] add-symbol-file not to print address truncated
Date: Sun, 04 May 2008 00:43:00 -0000	[thread overview]
Message-ID: <18461.19.864624.156635@localhost.localdomain> (raw)
In-Reply-To: <200805040053.27168.pedro@codesourcery.com>

Pedro Alves writes:
> Ah, that looks like paddress then, except for the width.

Right, I missed that.  Thanks.  I really don't care about width except that
that was what allowed me to reuse this function.

I can retest the patch without those bits then (which is pretty much an
obvious patch now) like:

	* symfile.c (add_symbol_file_command): Use paddress rather than
	hex_string to print the address.

Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.199
diff -F^\([(a-zA-Z0-9_]\|#define\) -u -p -u -r1.199 symfile.c
--- symfile.c	21 Apr 2008 14:25:16 -0000	1.199
+++ symfile.c	4 May 2008 00:11:11 -0000
@@ -2239,8 +2239,7 @@ add_symbol_file_command (char *args, int
          entered on the command line. */
       section_addrs->other[sec_num].name = sec;
       section_addrs->other[sec_num].addr = addr;
-      printf_unfiltered ("\t%s_addr = %s\n",
-		       sec, hex_string ((unsigned long)addr));
+      printf_unfiltered ("\t%s_addr = %s\n", sec, paddress (addr));
       sec_num++;
 
       /* The object's sections are initialized when a


  reply	other threads:[~2008-05-04  0:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03 23:48 Adam Nemet
2008-05-03 23:52 ` Pedro Alves
2008-05-03 23:53   ` Adam Nemet
2008-05-04  0:29     ` Pedro Alves
2008-05-04  0:43       ` Adam Nemet [this message]
2008-05-04  3:39         ` Daniel Jacobowitz
2008-05-04  7:24           ` Adam Nemet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18461.19.864624.156635@localhost.localdomain \
    --to=anemet@caviumnetworks.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox