From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2092 invoked by alias); 17 Apr 2008 21:25:33 -0000 Received: (qmail 2078 invoked by uid 22791); 17 Apr 2008 21:25:32 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Apr 2008 21:25:06 +0000 Received: from kahikatea.snap.net.nz (166.60.255.123.dynamic.snap.net.nz [123.255.60.166]) by viper.snap.net.nz (Postfix) with ESMTP id 19A273DA26D; Fri, 18 Apr 2008 09:24:59 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 8D1D48FC6D; Fri, 18 Apr 2008 09:24:54 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <18439.49189.568452.141569@kahikatea.snap.net.nz> Date: Thu, 17 Apr 2008 21:25:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Avoid breakpoint query in MI In-Reply-To: References: <18439.18322.632208.43670@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.2.50.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00367.txt.bz2 > > =A0 extern void current_interp_command_loop (void); > > =A0 /* Returns opaque data associated with the top-level interpreter. = =A0*/ > > =A0 extern void *top_level_interpreter_data (void); > > + extern void *interp_top_level (void); >=20 > Please name this top_level_interpreter. Also, the return type > should be "struct interp*". In fact, I have a not-yet-submitted > patches which does just that :-) OK. > > *************** See set/show multiple-symbol.")); > > *** 524,530 **** > > =A0=20 > > =A0 =A0 /* If select_mode is "all", then do not print the multiple-cho= ice > > =A0 =A0 =A0 =A0menu and act as if the user had chosen choice "1" (all)= . =A0*/ > > ! =A0 if (select_mode =3D=3D multiple_symbols_all) > > =A0 =A0 =A0 args =3D "1"; > > =A0 =A0 else > > =A0 =A0 =A0 { > > --- 526,533 ---- > > =A0=20 > > =A0 =A0 /* If select_mode is "all", then do not print the multiple-cho= ice > > =A0 =A0 =A0 =A0menu and act as if the user had chosen choice "1" (all)= . =A0*/ > > ! =A0 if (select_mode =3D=3D multiple_symbols_all > > ! =A0 =A0 =A0 || ui_out_is_mi_like_p (interp_ui_out (interp_top_level = ()))) > > =A0 =A0 =A0 args =3D "1"; > > =A0 =A0 else > > =A0 =A0 =A0 { >=20 > I think that adding breakpoints on all symbols is better than silently > grabbing random symbol, so the above seems fine to me. Can somebody appr= ove > the linespec.c bit? I'm not sure I understand. When multiple-symbols is 'all' (the default) th= ere is no problem. When it's 'ask', it currently queries which we don't want to happen in MI. This appears to me to be an MI only change and within your domain. I don't think authority is devolved on a file by file basis, although clearly I'm not qualified to make such remarks. --=20 Nick http://www.inet.net.nz/~nick= rob