From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5466 invoked by alias); 11 Apr 2008 22:25:02 -0000 Received: (qmail 5396 invoked by uid 22791); 11 Apr 2008 22:25:00 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Apr 2008 22:24:32 +0000 Received: from kahikatea.snap.net.nz (23.31.255.123.static.snap.net.nz [123.255.31.23]) by viper.snap.net.nz (Postfix) with ESMTP id 1DA013D9AD4; Sat, 12 Apr 2008 10:24:30 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 15C058FC6D; Sat, 12 Apr 2008 10:24:29 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18431.58651.987061.943598@kahikatea.snap.net.nz> Date: Fri, 11 Apr 2008 23:22:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: -var-update @ In-Reply-To: References: <200803261754.10513.vladimir@codesourcery.com> <200804032209.53480.vladimir@codesourcery.com> <18421.14387.463657.822174@kahikatea.snap.net.nz> <200804041331.44206.vladimir@codesourcery.com> X-Mailer: VM 7.19 under Emacs 22.2.50.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00230.txt.bz2 > >> > Do you think you can write some test to go along this patch? > >> > >> We need some tests and documentation at some stage before the next release > >> but perhaps Bogdan can confirm that this patch works for him first. > > > > Well, if your patch fixes the issue that *you* saw, then it's already an > > improvement, and we better get it into the tree as soon as possible. > > Nick, for avoidance of doubt -- are you planning to finish this patch in > near future? If not, I'll pick it up. I think the patch is OK, so I don't know what to change there, but perhaps you mean write some tests. I must admit my enthusiasm has waned a bit and I've not started this yet. In either case, please feel free to finish it as you see appropriate. -- Nick http://www.inet.net.nz/~nickrob