Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: linux native async mode support
Date: Mon, 07 Apr 2008 00:06:00 -0000	[thread overview]
Message-ID: <18424.28834.573873.54124@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200804051328.43973.ghost@cs.msu.su>

 > > There's an extra "^done" because this is a CLI command entered in MI (and
 > > therfore case CLI_COMMAND: of captured_mi_execute_command).  There are many
 > > issues here like should we diallow immediate use of CLI commands now and
 > > require explicit use of "-interpreter-exec console"?
 > 
 > Probably not -- I don't see any immediate advantage from that.

The node "GDB/MI Compatibility with CLI" explains why.

 > > Then "-interpreter-exec 
 > > console next" doesn't emit "(gdb)/n" after "^running" when in asynchronous
 > > mode, so should we remove it from synchronous mode too (as you have suggested)?
 > 
 > This prompting is fairly confusing, so it could be that I've confused myself
 > as well, but I think "-interpreter-exec console next" actually *should* print
 > the prompt if the target is async-capable. The reason is that for MI mode,
 > we don't really care about terminal ownership issues, and then should not
 > care about sync_execution, and then this bit of code:
 > 
 >       else if (sync_execution)
 > 	{
 > 	  /* Don't print the prompt. We are executing the target in
 > 	     synchronous mode.  */
 > 	  args->action = EXECUTE_COMMAND_SUPPRESS_PROMPT;
 > 	  return;
 > 	}
 > 
 > in captured_mi_execute_command should be removed. In fact, I have a
 > patch-in-progress to do exactly that, and hopefully will be posting it later
 > today.

OK.

 > > But these are all MI issues and this test is meant to just be a mark in the
 > > sand for asynchronous mode, and one that I had lying around.  For the moment, I
 > > don't really want to work on it further
 > 
 > Okay :-) Then, will you mind if I apply this patch either when I'm done with
 > another round of MI testsuite cleanups I'm doing today, or after the ^done
 > is gone, whichever proves more convenient?

I'll commit this as is then.  Then, of course, you can decide what changes you
wish to make.  Meanwhile I'll try to come up with some tests for floating
variable objects which will be more efficient use of my time.


 > >  > BTW, I'm not even sure that "^done" vs. "^running" + "^done" is so big
 > >  > difference that a helper function cannot be introduced.
 > > 
 > > The comment suggests that mi_gdb_test will not work but I have not revisited
 > > that since writing the test 18 months or so ago.  If true, that could also
 > > make helper functions difficult.
 > 
 > Do you happen to remember what race condition the comment mentions?

I must have copied the comment from mi-simplerun.exp and I think I found it
necessary with my asynchronous branch, although I can't be sure, and it may
not be be necessary with Pedro's version (.i.e. mainline).

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2008-04-06  6:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14  8:11 Pedro Alves
2008-03-14 21:17 ` Daniel Jacobowitz
2008-03-17 16:05   ` Pedro Alves
2008-03-17 22:05     ` Daniel Jacobowitz
2008-03-18 23:27       ` Pedro Alves
2008-03-18 23:58         ` Daniel Jacobowitz
2008-03-21 15:55         ` Daniel Jacobowitz
2008-03-21 17:19           ` Pedro Alves
2008-03-28 14:48             ` Maciej W. Rozycki
2008-03-28 16:07               ` Pedro Alves
2008-03-28 16:13                 ` Daniel Jacobowitz
2008-03-28 16:40                   ` Pedro Alves
2008-03-18  0:06     ` Nick Roberts
2008-03-18 23:28       ` Pedro Alves
2008-03-19  3:59         ` Nick Roberts
2008-03-19 16:25           ` Luis Machado
2008-03-19 23:19             ` Pedro Alves
2008-03-19 23:26               ` Pedro Alves
2008-03-20  1:58               ` Nick Roberts
2008-03-21 15:47                 ` Daniel Jacobowitz
2008-03-21 15:49       ` Daniel Jacobowitz
2008-03-21 23:02         ` Nick Roberts
2008-03-22  1:25           ` Daniel Jacobowitz
2008-03-22 22:06             ` Nick Roberts
2008-04-01 14:00               ` Daniel Jacobowitz
2008-04-01 15:17               ` Vladimir Prus
2008-04-01 20:09                 ` Nick Roberts
2008-04-04 12:34                   ` Vladimir Prus
2008-04-05 17:20                     ` Nick Roberts
2008-04-05 22:07                       ` Vladimir Prus
2008-04-07  0:06                         ` Nick Roberts [this message]
2008-04-07  2:33                         ` Nick Roberts
2008-03-18  2:47     ` Nick Roberts
2008-03-14 23:10 ` Nick Roberts
2008-03-15  1:58   ` Pedro Alves
2008-03-15  3:11     ` Daniel Jacobowitz
2008-03-17 23:41     ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18424.28834.573873.54124@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox