From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22117 invoked by alias); 30 Mar 2008 05:13:42 -0000 Received: (qmail 22108 invoked by uid 22791); 30 Mar 2008 05:13:41 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 30 Mar 2008 05:13:16 +0000 Received: from kahikatea.snap.net.nz (32.60.255.123.dynamic.snap.net.nz [123.255.60.32]) by viper.snap.net.nz (Postfix) with ESMTP id 27DB13D9D51; Sun, 30 Mar 2008 18:13:09 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 3C5018FC6D; Sun, 30 Mar 2008 17:09:03 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18415.8302.588187.39111@kahikatea.snap.net.nz> Date: Sun, 30 Mar 2008 05:13:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: cleanup mi error message handling In-Reply-To: References: <200803241830.11759.pedro@codesourcery.com> <18408.9553.683746.929167@kahikatea.snap.net.nz> <20080324223840.GA20307@caradoc.them.org> <18408.15132.721049.31408@kahikatea.snap.net.nz> <20080325005941.GA27677@caradoc.them.org> <18408.21818.695835.725321@kahikatea.snap.net.nz> <20080325021214.GA31594@caradoc.them.org> X-Mailer: VM 7.19 under Emacs 22.1.92.3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00487.txt.bz2 > > `"&" STRING-OUTPUT' > > The log stream contains debugging messages being produced by GDB's > > internals. > > > > I still think that means we shouldn't be producing them for > > errors. >From mi-interp.c: /* Create MI channels */ mi->err = mi_console_file_new (raw_stdout, "&", '"'); mi->log = mi->err; Maybe the documentation is imprecise but it's pretty clear from the code that this channel was intended for errors. > I agree. What happens now is that on errors, Eclipse shows the error message > in red. Good, however since it does not show the MI commands user will know > what something is wrong, but won't have any clue why. Maybe that's a shortcoming of Eclipse. And if it is a problem then it is surely one which an Eclipse developer should raise. > If the point is just > to show to the user that some error has happened, then the ^error is pretty > sufficient. I've said why I don't think it's sufficient but I'm not going to repeat myself. > And if we enable logging of MI commands, user can see the > information even if nothing goes to "&" channel. And nothing goes to the console. Same old story. > So I'd agree that removing those error messages is good. I plan to review > the patch in detail next week. -- Nick http://www.inet.net.nz/~nickrob