From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32256 invoked by alias); 19 Mar 2008 09:56:10 -0000 Received: (qmail 32208 invoked by uid 22791); 19 Mar 2008 09:56:09 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 09:55:44 +0000 Received: from kahikatea.snap.net.nz (120.63.255.123.dynamic.snap.net.nz [123.255.63.120]) by viper.snap.net.nz (Postfix) with ESMTP id E19C23DA4AA; Wed, 19 Mar 2008 22:55:41 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id C3E718FC6D; Wed, 19 Mar 2008 21:55:40 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18400.58139.937426.478457@kahikatea.snap.net.nz> Date: Wed, 19 Mar 2008 09:56:00 -0000 To: Jan Kratochvil Cc: bug-readline@gnu.org, gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [patch] Fix testsuite annotate-quit race (PR 544) In-Reply-To: <20080319092335.GA1995@host0.dyn.jankratochvil.net> References: <20080318225436.GA27374@host0.dyn.jankratochvil.net> <20080318231738.GA22432@caradoc.them.org> <20080319081056.GA32510@host0.dyn.jankratochvil.net> <18400.53985.920783.999852@kahikatea.snap.net.nz> <20080319092335.GA1995@host0.dyn.jankratochvil.net> X-Mailer: VM 7.19 under Emacs 22.1.92.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00273.txt.bz2 > * I still face testsuite results flutter making the day-to-day regressions > evaluations expensive. Most of the flutters are fixed in gdb-6.8 but still > some of them remain, this fix is for one of them. > > * I do not care much if it FAILs or PASSes but it must not flutter. > > * I found it is a known PR 544 only after I fixed it. > > * I fixed it as it was a nuisance reported by the courtesy of Roland McGrath. > > * As the SIGINT blocking in RL_REDISPLAY fixes the race (1 of 10 cases to 0 of > 350 cases during my test) I find it a proof there must be some race. > In fact if you check that RL_REDISPLAY modifies a lot of global variables > being tangled by SIGINT-handler-called RL_FREE_LINE_STATE it is clear some > locking is missing there. > > * Sure I am fine to keep the patch in the local branch. I find it to resolve such matters easier by talking person to person than communicating by e-mail, but here goes: You say "I am fine to keep the patch in the local branch." but from the preceding points it sounds anything but fine. I don't have the understanding of readline to make a judgement on your patch but I am just worried it will break something for Emacs just as a previous change that you and Daniel made to readline did. It appear to me that the only problem this FAIL is causing is with the actual running of the testsuite. I would be quite happy if this test was just removed. Would that work for everyone else? -- Nick http://www.inet.net.nz/~nickrob