From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5018 invoked by alias); 19 Mar 2008 08:46:56 -0000 Received: (qmail 5009 invoked by uid 22791); 19 Mar 2008 08:46:55 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 08:46:30 +0000 Received: from kahikatea.snap.net.nz (55.61.255.123.dynamic.snap.net.nz [123.255.61.55]) by viper.snap.net.nz (Postfix) with ESMTP id DAD333DAA8F; Wed, 19 Mar 2008 21:46:27 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 6E2FF8FC6D; Wed, 19 Mar 2008 20:46:26 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18400.53985.920783.999852@kahikatea.snap.net.nz> Date: Wed, 19 Mar 2008 08:46:00 -0000 To: Jan Kratochvil Cc: bug-readline@gnu.org, gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [patch] Fix testsuite annotate-quit race (PR 544) In-Reply-To: <20080319081056.GA32510@host0.dyn.jankratochvil.net> References: <20080318225436.GA27374@host0.dyn.jankratochvil.net> <20080318231738.GA22432@caradoc.them.org> <20080319081056.GA32510@host0.dyn.jankratochvil.net> X-Mailer: VM 7.19 under Emacs 22.1.92.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00271.txt.bz2 > > > PR 544 des gdb.cp/annota2.exp and gdb.cp/annota3.exp sometimes FAIL with: > > > FAIL: gdb.cp/annota3.exp: annotate-quit (pattern 1) > ... > > Isn't this a bug in GDB, not a bug in the test? > > You are right it is probably better to fix it in readline. Annotations are being deprecated and the original bug report is nearly six years old. As as variation of the old adage, I would suggest that "Since no-one appears to mind it's broke, don't fix it". The danger of making a fix in readline, of course, is that you break annotations elsewhere, where it's more important. -- Nick http://www.inet.net.nz/~nickrob