From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16157 invoked by alias); 18 Mar 2008 00:06:10 -0000 Received: (qmail 15256 invoked by uid 22791); 18 Mar 2008 00:06:07 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Mar 2008 00:05:42 +0000 Received: from kahikatea.snap.net.nz (89.30.255.123.static.snap.net.nz [123.255.30.89]) by viper.snap.net.nz (Postfix) with ESMTP id 0489F3DAB78; Tue, 18 Mar 2008 13:05:40 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 647B48FC6D; Tue, 18 Mar 2008 12:05:37 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18399.1872.669733.441391@kahikatea.snap.net.nz> Date: Tue, 18 Mar 2008 00:06:00 -0000 To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: linux native async mode support In-Reply-To: <200803171605.24276.pedro@codesourcery.com> References: <200803140810.22883.pedro@codesourcery.com> <20080314211646.GK31663@caradoc.them.org> <200803171605.24276.pedro@codesourcery.com> X-Mailer: VM 7.19 under Emacs 23.0.60.42 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00251.txt.bz2 > New patch attached. No regressions in async mode other than > the same defines.exp regressions, and no regressions when async > mode is disabled. --- tested on x86-64-unknown-linux-gnu. I've tested it (evidently on i686-linux-gnu) with set GDBFLAGS "-ex \"maint set linux-async on\"" in site.exp, ignoring commands.exp and just got a few extra exceptions: FAIL: gdb.mi/mi-var-child-f.exp: mi runto MAIN__ (timeout) FAIL: gdb.mi/mi-var-child-f.exp: create local variable array FAIL: gdb.mi/mi2-simplerun.exp: continue to end (1) FAIL: gdb.threads/pthreads.exp: check backtrace from main thread Are you going to add any new tests? My original test file mi-async.exp (attached below) works with your patch when GDBFLAGS is toggled as above. It would be be good to have a test for -exec-interrupt too. -- Nick http://www.inet.net.nz/~nickrob --------------------------------- # Copyright 2008 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or # (at your option) any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. # # Test asynchronous Machine Interface (MI) operations # load_lib mi-support.exp set saved_gdbflags $GDBFLAGS set GDBFLAGS "-ex \"maint set linux-async on\"" gdb_exit if [mi_gdb_start] { continue } set testfile "basics" set srcfile ${testfile}.c set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } { untested mi-async.exp return -1 } mi_delete_breakpoints mi_gdb_reinitialize_dir $srcdir/$subdir mi_gdb_load ${binfile} # mi_gdb_test cannot be used for asynchronous commands because there are # two prompts involved and this can lead to a race condition. proc linux_async_tests {} { global mi_gdb_prompt global hex set line_main_head [gdb_get_line_number "main ("] set line_main_body [expr $line_main_head + 2] set line_main_next [expr $line_main_head + 3] send_gdb "start\n" gdb_expect { -re ".*\\^running\r\n\\^done\r\n$mi_gdb_prompt" { gdb_expect { -re "\\*stopped,thread-id=\"0\",frame=\{addr=\"$hex\",func=\"main\",args=\\\[\\\],file=\".*basics.c\",line=\"$line_main_body\"\}\r\n$mi_gdb_prompt$" { pass "Asynchronous response after start command" } -re ".*$mi_gdb_prompt$" { fail "Asynchronous response after start command (2)" } timeout { fail "Asynchronous response after start command (timeout 2)" } } } -re ".*$mi_gdb_prompt$" { fail "Asynchronous response after start command (1)" } timeout {fail "Asynchronous response after start command (timeout 1)"} } send_gdb "next\n" gdb_expect { -re "\\^running\r\n\\^done\r\n$mi_gdb_prompt" { gdb_expect { -re "\\*stopped,reason=\"end-stepping-range\",thread-id=\"0\",frame=\{addr=\"$hex\",func=\"main\",args=\\\[\\\],file=\".*basics.c\",line=\"$line_main_next\"\}\r\n$mi_gdb_prompt$" { pass "Asynchronous response after next command" } -re ".*$mi_gdb_prompt$" { fail "Asynchronous response after next command (2)" } timeout { fail "Asynchronous response after next command (timeout 2)" } } } -re ".*$mi_gdb_prompt$" { fail "Asynchronous response after next command (1)" } timeout {fail "Asynchronous response after next command (timeout 1)"} } send_gdb "start\n" gdb_expect { -re ".*\\^running\r\n\\^done\r\n$mi_gdb_prompt" { gdb_expect { -re "\\*stopped,thread-id=\"0\",frame=\{addr=\"$hex\",func=\"main\",args=\\\[\\\],file=\".*basics.c\",line=\"$line_main_body\"\}\r\n$mi_gdb_prompt$" { pass "Asynchronous response after (re) start" } -re ".*$mi_gdb_prompt$" { fail "Asynchronous response after (re) start (2)" } timeout { fail "Asynchronous response after (re) start (timeout 2)" } } } -re ".*$mi_gdb_prompt$" { fail "Asynchronous response after (re) start (1)" } timeout {fail "Asynchronous response after (re) start (timeout 1)"} } } #if [istarget "i386-*-linux-gnu"] then { linux_async_tests #} mi_gdb_exit set GDBFLAGS $saved_gdbflags return 0