From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3434 invoked by alias); 9 Mar 2008 03:32:08 -0000 Received: (qmail 3426 invoked by uid 22791); 9 Mar 2008 03:32:08 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 09 Mar 2008 03:31:42 +0000 Received: from kahikatea.snap.net.nz (252.31.255.123.static.snap.net.nz [123.255.31.252]) by viper.snap.net.nz (Postfix) with ESMTP id 0CA423DA80C; Sun, 9 Mar 2008 16:31:35 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 6173A8FC6D; Sun, 9 Mar 2008 16:31:26 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18387.23053.337099.569702@kahikatea.snap.net.nz> Date: Sun, 09 Mar 2008 03:32:00 -0000 To: Aleksandar Ristovski Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [patch] fix for PR2424 In-Reply-To: <47D32B57.5020203@qnx.com> References: <47CED9FB.7090904@qnx.com> <47D32B57.5020203@qnx.com> X-Mailer: VM 7.19 under Emacs 23.0.60.33 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00077.txt.bz2 > ...(I am not working on CDT but I was explained that > missing "reason" is to blame, and after the patch I proposed I was told > things now work as expected). As expected for CDT, you mean? > @Nick: I think the breakpoint should be reported. The fact that it is > temporary doesn't make it much different than a regular breakpoint... but > maybe I'm missing something. It's only a message so it's probably not that important, but when the user sees: Breakpoint 1, main (argc=1, argv=0xbf844314) at myprog.c:95 and then looks at the breakpoint list and breakpoint 1 isn't there, he might get confused. Likewise for a frontend with a reason like "breakpoint-hit". Perhaps a new one, like "temporary-breakpoint-hit", is needed. >... > + /* Delete the breakpoint we stopped at, if it wants to be deleted. > + Delete any breakpoint that is to be deleted at the next stop. */ > + breakpoint_auto_delete (stop_bpstat); > annotate_stopped (); > observer_notify_normal_stop (stop_bpstat); > } If anyone ever uses observer_notify_normal_stop, then presumably breakpoint_auto_delete would need to go after that. -- Nick http://www.inet.net.nz/~nickrob