From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32746 invoked by alias); 20 Feb 2008 19:38:01 -0000 Received: (qmail 32729 invoked by uid 22791); 20 Feb 2008 19:38:00 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Feb 2008 19:37:34 +0000 Received: from kahikatea.snap.net.nz (26.31.255.123.static.snap.net.nz [123.255.31.26]) by viper.snap.net.nz (Postfix) with ESMTP id F14D33DA873; Thu, 21 Feb 2008 08:37:26 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id B015E8FC6D; Thu, 21 Feb 2008 08:37:25 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18364.33141.401534.130390@kahikatea.snap.net.nz> Date: Wed, 20 Feb 2008 19:38:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com, Eli Zaretskii Subject: Re: [RFA] Implement -thread-info. In-Reply-To: <200802201427.36288.vladimir@codesourcery.com> References: <200802171833.26673.vladimir@codesourcery.com> <200802181038.04497.vladimir@codesourcery.com> <18361.64577.771676.184618@kahikatea.snap.net.nz> <200802201427.36288.vladimir@codesourcery.com> X-Mailer: VM 7.19 under Emacs 22.1.90.4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00337.txt.bz2 > > Also do you want to > > catch errors in print_stack_frame? > > Yes, why not? A typical error is when we have a char* parameter pointing to > something not very accessible, in which case I'd prefer print_stack_frame > to catch this error, as opposed to -thread-info outright dying. If there is an error then presumably you want MI to catch (and report) it. I don't know if this is a problem, in practice, because I don't know how to get print_stack_frame to fail. > > > I don't know what problem of return type you refer to -- can you > > > clarify? > > > > That, in Denis' patch, gdb_thread_info returns type enum gdb_rc but > > catch_exceptions_with_msg returns type int. (just like gdb_breakpoint and > > break_command_really did for a while). > > This problem does not exist in my patch, as catch_exceptions_with_msg is > just not used. You misunderstand. The problem you were asking about was in Denis' patch. I never said it was in yours. -- Nick http://www.inet.net.nz/~nickrob