From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26299 invoked by alias); 20 Feb 2008 19:21:33 -0000 Received: (qmail 26287 invoked by uid 22791); 20 Feb 2008 19:21:32 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Feb 2008 19:20:56 +0000 Received: from kahikatea.snap.net.nz (26.31.255.123.static.snap.net.nz [123.255.31.26]) by viper.snap.net.nz (Postfix) with ESMTP id 228733DA848; Thu, 21 Feb 2008 08:20:54 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 6531A8FC6D; Thu, 21 Feb 2008 08:20:51 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18364.32147.39758.99346@kahikatea.snap.net.nz> Date: Wed, 20 Feb 2008 19:21:00 -0000 To: Joel Brobecker Cc: Vladimir Prus , gdb-patches@sourceware.org Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded In-Reply-To: <20080220163125.GA3669@adacore.com> References: <20080204214226.GF20922@adacore.com> <20080207063817.GA3907@adacore.com> <18347.45621.630420.453287@kahikatea.snap.net.nz> <200802080942.29622.ghost@cs.msu.su> <18348.1691.478013.310214@kahikatea.snap.net.nz> <20080214214246.GC3713@adacore.com> <18357.3708.628053.809241@kahikatea.snap.net.nz> <20080219190143.GH3713@adacore.com> <18363.13851.966889.923773@kahikatea.snap.net.nz> <20080220163125.GA3669@adacore.com> X-Mailer: VM 7.19 under Emacs 22.1.90.4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00336.txt.bz2 > So how about you submit a complete patch, following the usual protocol > rather than an abbreviated one? I'll review it promptly, and we can > put this episode behind us. As I said before, I reviewed the breakpoint.c > patch and it looked fine, so it's just a matter of taking a look at > the testsuite failures and adjust the testsuite accordingly (if > justified). Some or all of the other failures occur in these files: 2007-09-23 Vladimir Prus * gdb.base/annota1.exp: Adjust for 'info break' format changes. * gdb.base/annota3.exp: Likewise. * gdb.base/break.exp: Likewise. * gdb.base/condbreak.exp: Likewise. * gdb.base/pending.exp: Likewise. * gdb.base/sepdebug.exp: Likewise. * gdb.base/unload.exp: Likewise. * gdb.base/ovldbreak.exp: Likewise. So I'm surprised that Vladimir did not know there would be more than those in ovldbreak.exp (actually cp.base). It is possible for me to try to understand each of these changes and revert them but clearly it is far easier for Vladimir to do that as he made the changes in the first place. I will try to do that but I don't have the time at the moment. -- Nick http://www.inet.net.nz/~nickrob