From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-53969-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13332 invoked by alias); 5 Feb 2008 21:18:49 -0000
Received: (qmail 13280 invoked by uid 22791); 5 Feb 2008 21:18:47 -0000
X-Spam-Check-By: sourceware.org
Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Feb 2008 21:18:16 +0000
Received: from kahikatea.snap.net.nz (109.31.255.123.static.snap.net.nz [123.255.31.109]) 	by viper.snap.net.nz (Postfix) with ESMTP id ED5313DA018; 	Wed,  6 Feb 2008 10:18:13 +1300 (NZDT)
Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) 	id 358F28FC6D; Wed,  6 Feb 2008 10:18:12 +1300 (NZDT)
From: Nick Roberts <nickrob@snap.net.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18344.53908.438015.75204@kahikatea.snap.net.nz>
Date: Tue, 05 Feb 2008 21:18:00 -0000
To: "Marc Khouzam" <marc.khouzam@ericsson.com>
Cc: "Daniel Jacobowitz" <drow@false.org>, 	<gdb-patches@sourceware.org>
Subject: RE: [Patch] -var-evaluate-expression NAME [FORMAT]
In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA04290E99@ecamlmw720.eamcs.ericsson.se>
References: <18344.51774.858278.592849@kahikatea.snap.net.nz> 	<6D19CA8D71C89C43A057926FE0D4ADAA04290E99@ecamlmw720.eamcs.ericsson.se>
X-Mailer: VM 7.19 under Emacs 22.1.50.23
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-02/txt/msg00115.txt.bz2

 > You don't like my new patch? :-)
 > I feels less risky (and it's cleaner than
 > my orginal one.)

Well it's probably smaller than it looks as there are many formatting changes.
"Don't like" is probably too strong, it just seems a bit intrusive for a
feature that only you may use.  However, I don't object to your patch,...

 > My hesitation with your suggestion is that it
 > seems more risky to forget a case, and that it
 > is not as future-proof because it duplicates
 > some logic in mi-var-cmd and varobj.

...and it probably is safer.

-- 
Nick                                           http://www.inet.net.nz/~nickrob