From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28575 invoked by alias); 30 Jan 2008 08:51:12 -0000 Received: (qmail 28552 invoked by uid 22791); 30 Jan 2008 08:51:11 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Jan 2008 08:50:45 +0000 Received: from kahikatea.snap.net.nz (192.31.255.123.static.snap.net.nz [123.255.31.192]) by viper.snap.net.nz (Postfix) with ESMTP id 7F6863DA6CD; Wed, 30 Jan 2008 21:50:37 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 2959F8FC6D; Wed, 30 Jan 2008 21:50:32 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18336.14935.154345.686930@kahikatea.snap.net.nz> Date: Wed, 30 Jan 2008 09:30:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH: mi-cmd-file.c] In-Reply-To: References: <18309.37153.798074.919481@kahikatea.snap.net.nz> <18335.61046.331600.553026@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 23.0.50.40 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00782.txt.bz2 > I seems like this patch was checked in, and I see the following: > > FAIL: gdb.mi/mi-file.exp: request path info of current source file > (basics.c) > > and same for mi2-file.exp. Did you forgot to run testsuite, or forgot to > commit testsuite change? Yes, my mistake - sorry. I've checked in the changes below as obvious. -- Nick http://www.inet.net.nz/~nickrob 2008-01-30 Nick Roberts * gdb.mi/mi-file.exp, gdb.mi/mi2-file.exp (test_file_list_exec_source_file): Update to new macro-info field. *** mi-file.exp.~1.11.~ 2008-01-10 11:35:09.000000000 +1300 --- mi-file.exp 2008-01-30 21:42:59.000000000 +1300 *************** proc test_file_list_exec_source_file {} *** 64,70 **** set line_default [expr $line_main_body - $gdb_lines_to_list + 1] mi_gdb_test "111-file-list-exec-source-file" \ ! "111\\\^done,line=\"$line_default\",file=\"${srcfilepath}\",fullname=\"$fullname_syntax${srcfile}\"" \ "request path info of current source file (${srcfile})" } --- 64,70 ---- set line_default [expr $line_main_body - $gdb_lines_to_list + 1] mi_gdb_test "111-file-list-exec-source-file" \ ! "111\\\^done,line=\"$line_default\",file=\"${srcfilepath}\",fullname=\"$fullname_syntax${srcfile}\",macro-info=\"0\"" \ "request path info of current source file (${srcfile})" } *** mi2-file.exp.~1.11.~ 2008-01-10 11:35:10.000000000 +1300 --- mi2-file.exp 2008-01-30 21:43:06.000000000 +1300 *************** proc test_file_list_exec_source_file {} *** 64,70 **** set line_default [expr $line_main_body - $gdb_lines_to_list + 1] mi_gdb_test "111-file-list-exec-source-file" \ ! "111\\\^done,line=\"$line_default\",file=\"${srcfilepath}\",fullname=\"$fullname_syntax${srcfile}\"" \ "request path info of current source file (${srcfile})" } --- 64,70 ---- set line_default [expr $line_main_body - $gdb_lines_to_list + 1] mi_gdb_test "111-file-list-exec-source-file" \ ! "111\\\^done,line=\"$line_default\",file=\"${srcfilepath}\",fullname=\"$fullname_syntax${srcfile}\",macro-info=\"0\"" \ "request path info of current source file (${srcfile})" }