From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23426 invoked by alias); 27 Jan 2008 21:11:03 -0000 Received: (qmail 23415 invoked by uid 22791); 27 Jan 2008 21:11:02 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 27 Jan 2008 21:10:33 +0000 Received: from kahikatea.snap.net.nz (244.60.255.123.dynamic.snap.net.nz [123.255.60.244]) by viper.snap.net.nz (Postfix) with ESMTP id 331C93DA17A; Mon, 28 Jan 2008 10:10:26 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 84CF68FC6D; Mon, 28 Jan 2008 10:10:21 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18332.62269.25839.287045@kahikatea.snap.net.nz> Date: Sun, 27 Jan 2008 21:29:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Make mi_cmd_break_insert exception-safe. In-Reply-To: <200801271715.08542.vladimir@codesourcery.com> References: <200801271715.08542.vladimir@codesourcery.com> X-Mailer: VM 7.19 under Emacs 22.1.50.23 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00636.txt.bz2 > The attached patch make mi_cmd_break_insert exception-safe, so that it always > resets the hook it installs. There's new testcase that fails before the > patch, and works after. OK? Is this patch is on top of your earlier one? If so, I think that has to be approved before we can review this one. In fact there appear to be many changes in the pipeline that need to be resolved before the next release. > - Volodya > > [gdb] > * breakpoint.c (break_command_1): Return void. ^^^^^^^^^^^ That's a contradiction in terms, isn't it? -- Nick http://www.inet.net.nz/~nickrob