From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44994 invoked by alias); 9 Mar 2019 14:28:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44986 invoked by uid 89); 9 Mar 2019 14:28:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=escaped, nuisance, H*x:5.0, H*UA:6.1 X-HELO: sonic306-20.consmr.mail.ir2.yahoo.com Received: from sonic306-20.consmr.mail.ir2.yahoo.com (HELO sonic306-20.consmr.mail.ir2.yahoo.com) (77.238.176.206) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Mar 2019 14:28:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1552141708; bh=sn/OBmZ44uYAQgpxD3uXjsixei03nnagGHzXyF+TRYY=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=OI8r8D7LGyIaUhMs8YnK6X/uBFen2NfRiKBccyqwsOv7OSBdwB3utrpf/tgP5ppG/EfwcVdeBZtdoysz+a38f/tpfWuSfDv+/H/lu5q1/XFe1BlyKk2bx4Miebjo6j2bD6ZfdREgqcwLKKmUjUrYyU0gYP/Cx7T7L5sIA87la9Xb5v9SzbBdMzm4V//KzXPF5IotZ35Tkv1AK4capKsY1N59cnqYmkb+QBXYq7RPH+f1i3BBUd1lYcFLQ+Lp7s3BpByIlhhNZE58HjGyX/0vNHEyQbqkcDyLcKzlFlh7burn7JlU7p2/rU0tVL5qUdbpxCLJg+2+HjU2Putbrtgj2w== Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ir2.yahoo.com with HTTP; Sat, 9 Mar 2019 14:28:28 +0000 Date: Sat, 09 Mar 2019 14:28:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: GDB Patches Message-ID: <1828778750.3318305.1552141698307@mail.yahoo.com> In-Reply-To: <20190308210433.32683-1-tromey@adacore.com> References: <20190308210433.32683-1-tromey@adacore.com> Subject: Re: [RFC 8.3 0/3] Some style fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00209.txt.bz2 Am Freitag, 8. M=C3=A4rz 2019, 22:04:47 MEZ hat Tom Tromey Folgendes geschrieben:=20 > This series fixes some of the TUI/styling regressions noted by Pedro. > I would like to push this to the 8.3 branch as well. > > Patch #2 is a new feature that Eli mentioned.=C2=A0 Since it's an addition > to a feature that is also new in 8.3, it seemed reasonable to do at > this time. > > Let me know what you think. These patches work great for me. But while testing them I saw some weird behavior which was introduced with = the style patches. 1) Outside of TUI, escaped characters (< 040 and 0177) aren't handled corre= ctly any more when list'ing some source code, resulting in an endless loop. See print_source_lines_base(), I just added "++iter" in the last 2 if() blo= cks, that fixed it for me. 2) In TUI, scrolling right with the arrow keys, the first keypress doesn't = do anything. (that's just a very minor nuisance) 3) Again in TUI, scrolling right handles TABS and escaped characters as sin= gle characters, which just looks weird. Regards Hannes Domani