From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28728 invoked by alias); 14 Nov 2007 07:06:20 -0000 Received: (qmail 28719 invoked by uid 22791); 14 Nov 2007 07:06:19 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 Nov 2007 07:06:14 +0000 Received: from kahikatea.snap.net.nz (107.31.255.123.static.snap.net.nz [123.255.31.107]) by viper.snap.net.nz (Postfix) with ESMTP id 4E3C53DA4A3; Wed, 14 Nov 2007 20:06:10 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 797808FC6D; Wed, 14 Nov 2007 20:06:04 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18234.40538.721148.831465@kahikatea.snap.net.nz> Date: Wed, 14 Nov 2007 07:06:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [8/9] multiple locations In-Reply-To: References: <18233.20228.172834.464875@kahikatea.snap.net.nz> <200711131105.10906.vladimir@codesourcery.com> <20071113224704.GB27266@adacore.com> X-Mailer: VM 7.19 under Emacs 23.0.50.46 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00262.txt.bz2 > As I say in another email, I might be able to implement using > as address in all cases. I don't pretend to understand the code but the patch below seems to work for me (probably not all cases). > But generally, trying to keeping CLI back compatible have to stop > at some time -- if we keep this "don't break CLI clients even if > CLI clients were deprecated from some time" attitude, it will result > in new features being available via MI only. Focussing on the issue at hand, we're just talking about making a minor adjustment to the format of "info breakpoints", for the case of pending breakpoints, to avoid breaking existing frontend(s). AFAIK no-one is talking about making this or anything else a MI only feature. -- Nick http://www.inet.net.nz/~nickrob 2007-11-14 Nick Roberts * breakpoint.c (print_one_breakpoint_location): Revert Enb field to old format. Discard breakpoint address if shared library is unloaded. *** breakpoint.c.~1.278.~ 2007-11-09 17:16:10.000000000 +1300 --- breakpoint.c 2007-11-14 19:52:35.000000000 +1300 *************** print_one_breakpoint_location (struct br *** 3555,3564 **** /* 4 */ annotate_field (3); if (part_of_multiple) ! ui_out_field_string (uiout, "enabled", ! loc->shlib_disabled ! ? (loc->enabled ? "y(p)" : "n(p)") ! : (loc->enabled ? "y" : "n")); else { int pending = (b->loc == NULL || b->loc->shlib_disabled); --- 3555,3561 ---- /* 4 */ annotate_field (3); if (part_of_multiple) ! ui_out_field_string (uiout, "enabled", loc->enabled ? "y" : "n"); else { int pending = (b->loc == NULL || b->loc->shlib_disabled); *************** print_one_breakpoint_location (struct br *** 3566,3576 **** state -- it will be apparent from the locations. */ if (header_of_multiple) pending = 0; ! ui_out_field_fmt (uiout, "enabled", "%c%s", ! bpenables[(int) b->enable_state], ! pending ? "(p)" : ""); ! if (!pending) ! ui_out_spaces (uiout, 3); } --- 3563,3570 ---- state -- it will be apparent from the locations. */ if (header_of_multiple) pending = 0; ! ui_out_field_fmt (uiout, "enabled", "%c", ! bpenables[(int) b->enable_state]); } *************** print_one_breakpoint_location (struct br *** 3704,3710 **** if (addressprint) { annotate_field (4); ! if (b->loc == NULL) ui_out_field_string (uiout, "addr", ""); else if (header_of_multiple) ui_out_field_string (uiout, "addr", ""); --- 3698,3704 ---- if (addressprint) { annotate_field (4); ! if (b->loc == NULL || loc->shlib_disabled) ui_out_field_string (uiout, "addr", ""); else if (header_of_multiple) ui_out_field_string (uiout, "addr", "");