From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16899 invoked by alias); 13 Nov 2007 07:15:33 -0000 Received: (qmail 16886 invoked by uid 22791); 13 Nov 2007 07:15:32 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Nov 2007 07:15:29 +0000 Received: from kahikatea.snap.net.nz (107.31.255.123.static.snap.net.nz [123.255.31.107]) by viper.snap.net.nz (Postfix) with ESMTP id 578AD3D9F2C; Tue, 13 Nov 2007 20:15:25 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id A193E8FC6D; Tue, 13 Nov 2007 20:15:17 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18233.20228.172834.464875@kahikatea.snap.net.nz> Date: Tue, 13 Nov 2007 07:15:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [8/9] multiple locations X-Mailer: VM 7.19 under Emacs 23.0.50.45 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00235.txt.bz2 Formerly, pending breakpoints were reported as: (gdb) inf bre Num Type Disp Enb Address What 1 breakpoint keep y cos now they're reported as: (gdb) inf bre Num Type Disp Enb Address What 1 breakpoint keep y(p) cos This can break a front end which parses the old output, and this is indeed the case for Emacs 22.1, which has already been released. Does the (p) add anything useful to the user? The manual says: An optional `(p)' suffix marks pending breakpoints Is that not clear from the word PENDING? If it's not needed can we please revert it to the old format? If it is needed can we find a format that doesn't break existing parsing? -- Nick http://www.inet.net.nz/~nickrob breakpoint.c: > > - ui_out_field_fmt (uiout, "enabled", "%c", bpenables[(int) b->enable_state]); > > - ui_out_spaces (uiout, 2); > > + if (part_of_multiple) > > + ui_out_field_string (uiout, "enabled", > > + loc->shlib_disabled > > + ? (loc->enabled ? "y(p)" : "n(p)") > > + : (loc->enabled ? "y" : "n"));