From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27843 invoked by alias); 9 Aug 2007 21:12:41 -0000 Received: (qmail 27738 invoked by uid 22791); 9 Aug 2007 21:12:41 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Aug 2007 21:12:35 +0000 Received: from kahikatea.snap.net.nz (134.41.255.123.static.snap.net.nz [123.255.41.134]) by viper.snap.net.nz (Postfix) with ESMTP id D591C3D9EA7; Fri, 10 Aug 2007 09:12:31 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id AAA308FC6D; Fri, 10 Aug 2007 09:12:30 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18107.33597.966320.942025@kahikatea.snap.net.nz> Date: Thu, 09 Aug 2007 21:12:00 -0000 To: Daniel Jacobowitz Cc: msnyder@sonic.net, gdb-patches@sourceware.org Subject: Re: [PATCH] dead code in mi-interp In-Reply-To: <20070809145727.GA27809@caradoc.them.org> References: <17268.12.7.175.2.1186611933.squirrel@webmail.sonic.net> <18106.20613.121153.810889@kahikatea.snap.net.nz> <20070809145727.GA27809@caradoc.them.org> X-Mailer: VM 7.19 under Emacs 22.1.50.8 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00183.txt.bz2 > That's not what "no side effects" means - the code literally can't > ever have an effect. It creates a string which nothing uses. Why > keep it? OK, I hadn't realised that. Unless the original author (Andrew Cagney?) explains why it's not needed I would still prefer that it wasn't removed. It may be that it just wasn't hooked up because the asynchronous stuff was never completed. Once GDB can work asynchronously then it could be removed, if not needed. Presumably "no side effects" also means "can do no harm". -- Nick http://www.inet.net.nz/~nickrob