From: Nick Roberts <nickrob@snap.net.nz>
To: msnyder@sonic.net
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] memory leak, mi-cmd-var
Date: Fri, 29 Jun 2007 04:32:00 -0000 [thread overview]
Message-ID: <18052.32294.978000.582803@kahikatea.snap.net.nz> (raw)
In-Reply-To: <24204.12.7.175.2.1183085800.squirrel@webmail.sonic.net>
> 'nother one from Coverity.
>
> 2007-06-28 Michael Snyder <msnyder@access-company.com>
>
> * mi/mi-cmd-var.c (mi_cmd_var_set_format): Free strduped memory
> (Coverity). Also take the opportunity to call error earlier
> (before strdup).
I don't see why the string has to be duplicated in the first place or how
argv[1] could be NULL. Why not just:
*** mi-cmd-var.c 14 Jun 2007 10:12:15 +1200 1.33
--- mi-cmd-var.c 29 Jun 2007 15:35:10 +1200
*************** mi_cmd_var_set_format (char *command, ch
*** 209,217 ****
if (var == NULL)
error (_("mi_cmd_var_set_format: Variable object not found"));
! formspec = xstrdup (argv[1]);
! if (formspec == NULL)
! error (_("mi_cmd_var_set_format: Must specify the format as: \"natural\", \"binary\", \"decimal\", \"hexadecimal\", or \"octal\""));
len = strlen (formspec);
--- 209,215 ----
if (var == NULL)
error (_("mi_cmd_var_set_format: Variable object not found"));
! formspec = argv[1];
len = strlen (formspec);
> Index: mi/mi-cmd-var.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mi/mi-cmd-var.c,v
> retrieving revision 1.33
> diff -p -r1.33 mi-cmd-var.c
> *** mi/mi-cmd-var.c 13 Jun 2007 19:08:47 -0000 1.33
> --- mi/mi-cmd-var.c 29 Jun 2007 02:52:39 -0000
> *************** mi_cmd_var_set_format (char *command, ch
> *** 209,218 ****
> if (var == NULL)
> error (_("mi_cmd_var_set_format: Variable object not found"));
>
> ! formspec = xstrdup (argv[1]);
> ! if (formspec == NULL)
> error (_("mi_cmd_var_set_format: Must specify the format as: \"natural\", \"binary\", \"decimal\", \"hexadecimal\", or \"octal\""));
>
> len = strlen (formspec);
>
> if (strncmp (formspec, "natural", len) == 0)
> --- 209,220 ----
> if (var == NULL)
> error (_("mi_cmd_var_set_format: Variable object not found"));
>
> ! if (argv[1] == NULL)
> error (_("mi_cmd_var_set_format: Must specify the format as: \"natural\", \"binary\", \"decimal\", \"hexadecimal\", or \"octal\""));
>
> + formspec = xstrdup (argv[1]);
> + make_cleanup (xfree, formspec);
> +
> len = strlen (formspec);
>
> if (strncmp (formspec, "natural", len) == 0)
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2007-06-29 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 3:36 msnyder
2007-06-29 4:32 ` Nick Roberts [this message]
2007-06-29 4:35 ` msnyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18052.32294.978000.582803@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@sonic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox