From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 606 invoked by alias); 5 Jun 2007 12:56:13 -0000 Received: (qmail 598 invoked by uid 22791); 5 Jun 2007 12:56:12 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Jun 2007 12:56:06 +0000 Received: from kahikatea.snap.net.nz (115.63.255.123.dynamic.snap.net.nz [123.255.63.115]) by viper.snap.net.nz (Postfix) with ESMTP id 6F1723D92B3; Wed, 6 Jun 2007 00:56:03 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 2B0EF8F9CE; Wed, 6 Jun 2007 00:55:56 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18021.23899.394336.980207@kahikatea.snap.net.nz> Date: Tue, 05 Jun 2007 12:56:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list In-Reply-To: <20070604010633.GA927@caradoc.them.org> References: <18019.18081.448928.93993@kahikatea.snap.net.nz> <20070604010633.GA927@caradoc.them.org> X-Mailer: VM 7.19 under Emacs 22.1.50.10 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00049.txt.bz2 > > This change breaks the behaviour of annotations with commands that span > > multiple lines, like if, while, etc: > > Sorry, I didn't even know we had special annotations for this (and the > testsuite must not cover it)... Here's a test for gdb.base/annota3.exp. I can do the same for gdb.base/annota1.exp and gdb.cp/annota3.exp, if needed. -- Nick http://www.inet.net.nz/~nickrob 2007-06-06 Nick Roberts * gdb.base/annota3.exp: Test for if construct. *** annota3.exp 10 Jan 2007 06:59:09 +1300 1.12 --- annota3.exp 06 Jun 2007 00:50:22 +1200 *************** gdb_expect_list "annotation set at level *** 99,105 **** "set annotate 3" } ! # # info break: # --- 99,121 ---- "set annotate 3" } ! # ! # if construct: ! # ! send_gdb "if 1\n" ! gdb_expect { ! -re "\r\n\032\032post-prompt\r\n\r\n\032\032pre-commands\r\n >\r\n\032\032commands\r\n" { ! pass "start if construct" ! } ! timeout { fail "start if construct (timeout)" } ! } ! send_gdb "end\n" ! gdb_expect { ! -re "\r\n\032\032post-commands\r\n$gdb_prompt$" { ! pass "end if construct" ! } ! timeout { fail "end if construct (timeout)" } ! } # # info break: #