Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Taylor <dtaylor@emc.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: ping (was: [PATCH] Fix for QTro remote packet)
Date: Thu, 09 May 2013 19:06:00 -0000	[thread overview]
Message-ID: <18001.1368126370@usendtaylorx2l> (raw)

Just a ping -- any progress on reviewing this one line patch?

    From: David Taylor <dtaylor@emc.com>
    To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
    Sender: "gdb-patches-owner@sourceware.org" <gdb-patches-owner@sourceware.org>
    Date: Wed, 1 May 2013 13:38:06 -0400
    Subject: [PATCH] Fix for QTro remote packet

    In function remote_trace_set_readonly_regions in gdb/remote.c, the local
    variable 'offset' does not account for "QTro" at the start of the packet
    with the result that if there are any read-only regions, the packet is
    sent -- but without the "QTro" -- causing the remote stub to report that
    the packet is unsupported.


    For gdb/ChangeLog:

    2013-05-01  David Taylor  <dtaylor@emc.com>

	    * remote.c (remote_trace_set_readonly_regions): Do not overwrite
	    "QTro" at start of packet.

    Here's a one line patch to gdb/remote.c of gdb 7.6:

    --- remote.c~	2013-04-12 12:04:50.000000000 -0400
    +++ remote.c	2013-05-01 12:45:10.000000000 -0400
    @@ -10652,6 +10652,7 @@
	 return;			/* No information to give.  */

       strcpy (target_buf, "QTro");
    +  offset = strlen (target_buf);
       for (s = exec_bfd->sections; s; s = s->next)
	 {
	   char tmp1[40], tmp2[40];

    This is small enough that no copyright assignment should be needed, but
    EMC has one on file.

    David
    --
    David Taylor
    dtaylor@emc.com


             reply	other threads:[~2013-05-09 19:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09 19:06 David Taylor [this message]
2013-05-09 19:24 ` Pedro Alves
2013-05-09 20:09   ` David Taylor
2013-05-10 11:38     ` ping Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18001.1368126370@usendtaylorx2l \
    --to=dtaylor@emc.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox