Re: [PATCH v4 1/9] gdb: Move construct_inferior_arguments to gdbsupport

Simon Marchi
2020-05-20T16:40:17Z

On 2020-05-20 12:37 p.m., Michael Weghorn wrote:
> On 13/05/2020 17.05, Simon Marchi wrote:
>> On 2020-05-13 11:01 a.m., Michael Weghorn wrote:
>>> On 13/05/2020 16.39, Simon Marchi wrote:
>>>> On 2020-05-13 5:47 a.m., Michael Weghorn via Gdb-patches wrote:
>>>>> This moves the function construct_inferior_arguments from
>>>>> gdb/inferior.h and gdb/infcmd.c to gdbsupport/common-inferior.{h,cc}.
>>>>> While at it, also move the function's comment to the header file
>>>>> to align with current standards.
>>>>>
>>>>> The intention is to use it from gdbserver in a follow-up commit.
>>>>
>>>> Hi Michael,
>>>>
>>>> The series LGTM. I think all we need now is to wait for your copyright assignment to
>>>> be completed?
>>>>
>>>> Simon
>>>>
>>> Hi Simon,
>>>
>>> thank you again for all help.
>>>
>>> I've signed the copyright assignment last week and sent it by email, but
>>> haven't received an FSF-signed version back so far.
>>>
>>> Michael
>>>
>>
>> Ok, let me know when you hear back.
>>
>> Simon
>>
>
> I have received a reply with the FSF-signed version of the copyright
> assignment now.
>
> Do you need additional information on that? (e.g. a copy of the
> assignment or the lines in the "INFORMATION FOR THE MAINTAINER(S)"
> section in the email that contains the answers of some to the questions
> from the initial form from
> http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future
> )

No, thanks, I can see your entry in the copyright assigment file, so that's fine.

We can look into merging your series as soon as the last question about the way
of passing args to gdbserver is settled.

Simon