Re: [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases

Simon Marchi
2020-05-12T16:11:04Z

On 2020-05-12 11:48 a.m., Michael Weghorn wrote:
> On 07/05/2020 21.29, Simon Marchi wrote:
>> On 2020-04-29 11:45 a.m., Christian Biesinger via Gdb-patches wrote:
>>> On Wed, Apr 29, 2020 at 10:25 AM Christian Biesinger
>>> <cbiesinger@google.com> wrote:
>>>>
>>>> Can you clarify which revision your patch is against? My files look
>>>> nothing like the ones you are patching.
>>>
>>> Oh, I see now that this patch applies on top of the other patch series you sent.
>>
>> I was also confused, normally the patch 0/N is the cover letter, not a patch
>> to apply.
>>
>> Simon
>>
>
> Sorry for the confusion! It's the first time I'm contributing to a
> project using this workflow and I misunderstood how to properly do it.

It's not a big deal, it's just that I wonder how you did it. The headers of you
messages say you've use git-send-email, and git-send-email numbers patches starting
as one, AFAIK.

> For the new version of the patch series, the patches now actually start
> with "PATCH v3 1/6".
> This also means that the patch numbers are no longer the same as in the
> previous version, which was no longer the case due to added/removed patches.
>
> I've declared all patches as "v3", so all patches in the series have the
> same version number again. (previous "[PATCH v2 1/4]" had v2 already,
> while the others didn't.)

That's fine, good choice.

>
> I hope this is OK, but am happy to hear about a better way to do this in
> the future.

No worries, the patch numbering was just a bit unexpected, that's all :).

Simon