Re: [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases

Michael Weghorn
2020-05-12T16:24:56Z

On 12/05/2020 18.11, Simon Marchi wrote:
> On 2020-05-12 11:48 a.m., Michael Weghorn wrote:
>> On 07/05/2020 21.29, Simon Marchi wrote:
>>> On 2020-04-29 11:45 a.m., Christian Biesinger via Gdb-patches wrote:
>>>> On Wed, Apr 29, 2020 at 10:25 AM Christian Biesinger
>>>> <cbiesinger@google.com> wrote:
>>>>>
>>>>> Can you clarify which revision your patch is against? My files look
>>>>> nothing like the ones you are patching.
>>>>
>>>> Oh, I see now that this patch applies on top of the other patch series you sent.
>>>
>>> I was also confused, normally the patch 0/N is the cover letter, not a patch
>>> to apply.
>>>
>>> Simon
>>>
>>
>> Sorry for the confusion! It's the first time I'm contributing to a
>> project using this workflow and I misunderstood how to properly do it.
>
> It's not a big deal, it's just that I wonder how you did it. The headers of you
> messages say you've use git-send-email, and git-send-email numbers patches starting
> as one, AFAIK.

It actually took me a while to find out as well. 'git-format-patch' (and
thus 'git-send-email') have a '--start-number' parameter, and I used
'--start-number=0', after seeing that other patch submissions started
with "[PATCH 0/N]", but missing that those were not actual patches.

Michael