Re: [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases

Simon Marchi
2020-05-07T19:29:50Z

On 2020-04-29 11:45 a.m., Christian Biesinger via Gdb-patches wrote:
> On Wed, Apr 29, 2020 at 10:25 AM Christian Biesinger
> <cbiesinger@google.com> wrote:
>>
>> On Wed, Apr 29, 2020 at 6:17 AM Michael Weghorn via Gdb-patches
>> <gdb-patches@sourceware.org> wrote:
>>>
>>> Allow construct_inferior_arguments to handle zero args
>>> and have it return a std::string, similar to how
>>> stringify_argv in gdbsupport/common-utils does.
>>>
>>> Also, add a const qualifier for the second parameter,
>>> since it is only read, not written to.
>>>
>>> The intention is to replace some existing uses of
>>> stringify_argv by construct_inferior_arguments
>>> in a subsequent step, since construct_inferior_arguments
>>> properly handles special characters, while stringify_argv
>>> doesn't.
>>
>> Can you clarify which revision your patch is against? My files look
>> nothing like the ones you are patching.
>
> Oh, I see now that this patch applies on top of the other patch series you sent.

I was also confused, normally the patch 0/N is the cover letter, not a patch
to apply.

Simon