From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fnNMOyESy2gdTwgAWB0awg (envelope-from ) for ; Wed, 17 Sep 2025 15:55:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1758138913; bh=kUzXiYHq46FaaYnNNv5/Qvcvs18IdAHdapy3oi8WMl8=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Nfk0/apaSY1UVDvG1OSCPu+fOC5ObpxnH7JOJDKc5nD6l209jcwNE4lpov8vHPqfo cAQi2ZEO5V39ZpLeY1it4ao8n5ToWK+QlLDZ56pNaUOJkIeXaFjoKz308WvwkdzshF JCb8GVQcWSlx7QY50ikchs2iSXla9gOix4sMrhug= Received: by simark.ca (Postfix, from userid 112) id E18B31E04C; Wed, 17 Sep 2025 15:55:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=nlLwgaPM; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 030991E04C for ; Wed, 17 Sep 2025 15:55:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9484B3858405 for ; Wed, 17 Sep 2025 19:55:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9484B3858405 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=nlLwgaPM Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 19C2B3858C66 for ; Wed, 17 Sep 2025 19:51:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19C2B3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 19C2B3858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758138711; cv=none; b=Xk5YE9To8ff+pxMyzmSxDX5tbVEgEo1v8jHHphf8TBxSYMlEWbrSL/2xjoKYAHc3A1T/IrIPHHw7ulH2WAKfK9wSvwJ639AdCDJkFaTq/FZ9hWuQxHZu5ZZYz4NhOIwiaxrO3roFZCL+iyJy8dqDpTaPnsMgAM+0vlcWnMgFf0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758138711; c=relaxed/simple; bh=kUzXiYHq46FaaYnNNv5/Qvcvs18IdAHdapy3oi8WMl8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NqBVnPyf/PTCL0/JIx5E2iEr9yJtKCR6cG8A8XqRbxAkGX9SgA1RHQFxdicIj43y4nRN2IL9LjY7Cbz8vszsH+/P6Zy3kGuGYoAC9/TLmwoyAYRpRlRQ2PhgzTP4R0xO7GDzXaK+q1tVvS6CVVCQhDeXHADHFuij9pwK4OH/qjY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19C2B3858C66 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1758138710; bh=kUzXiYHq46FaaYnNNv5/Qvcvs18IdAHdapy3oi8WMl8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=nlLwgaPMOA7/DEtFweehGtEVgLddvn89+61yI8VP8iSu+PT5L4LliB1BxA7uKw71w Ybopvvfdf449KmBxjMnkqUyFx925hi+PsUVh6vqm/6+aG3rrLmM3ikE6+SSTEyfEDp aae74xs7759EmY6c350Z8ixoqG/dhTtDv/2WkDEs= Received: by simark.ca (Postfix) id 7F0871E04C; Wed, 17 Sep 2025 15:51:50 -0400 (EDT) Message-ID: <17c08ef5-d8bc-4632-8c61-2f42ec5b124e@simark.ca> Date: Wed, 17 Sep 2025 15:51:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Have gdb.ThreadExitedEvent inherit from gdb.ThreadEvent To: Tom Tromey , gdb-patches@sourceware.org References: <20250917145154.2690156-1-tromey@adacore.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250917145154.2690156-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/17/25 10:51 AM, Tom Tromey wrote: > The documentation says that ThreadExitedEvent is derived from > ThreadEvent, but the code does not actually implement this. > > This patch fixes the problem. I propose applying this to gdb 17 as > well. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33444 > --- > gdb/python/py-event-types.def | 2 +- > gdb/testsuite/gdb.python/py-thread-exited.py | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gdb/python/py-event-types.def b/gdb/python/py-event-types.def > index 15cd9faae69..83167f36163 100644 > --- a/gdb/python/py-event-types.def > +++ b/gdb/python/py-event-types.def > @@ -54,7 +54,7 @@ GDB_PY_DEFINE_EVENT_TYPE (new_thread, > GDB_PY_DEFINE_EVENT_TYPE (thread_exited, > "ThreadExitedEvent", > "GDB thread exited event object", > - event_object_type); > + thread_event_object_type); > > GDB_PY_DEFINE_EVENT_TYPE (new_inferior, > "NewInferiorEvent", > diff --git a/gdb/testsuite/gdb.python/py-thread-exited.py b/gdb/testsuite/gdb.python/py-thread-exited.py > index ef5a2441b8e..f725bd585c9 100644 > --- a/gdb/testsuite/gdb.python/py-thread-exited.py > +++ b/gdb/testsuite/gdb.python/py-thread-exited.py > @@ -26,6 +26,8 @@ def thread_exited_handler(event): > global threadOneExit, threadTwoExit, mainThreadExit > print("{}".format(event)) > assert isinstance(event, gdb.ThreadExitedEvent) > + # Also check the inheritance. > + assert isinstance(event, gdb.ThreadEvent) > if threadOneExit == "": > threadOneExit = "event type: thread-exited. global num: {}".format( > event.inferior_thread.global_num > > base-commit: 311378bc3b871b199f439152c39debb7ec02e21c > -- > 2.51.0 > Approved-By: Simon Marchi Did you quickly go through the other event types to make sure there aren't others which have the same problem? Simon