From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7389 invoked by alias); 30 Nov 2016 20:11:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7334 invoked by uid 89); 30 Nov 2016 20:11:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 20:11:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED53A3F1F5; Wed, 30 Nov 2016 20:11:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUKB73f002326; Wed, 30 Nov 2016 15:11:08 -0500 Subject: Re: [PATCH v2 5/8] Fix test names starting with uppercase using multi-line gdb_test/mi_gdb_test To: Luis Machado , gdb-patches@sourceware.org References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-6-git-send-email-lgustavo@codesourcery.com> From: Pedro Alves Message-ID: <17bcdc1f-8f2c-92af-1b76-c0558c22b2c2@redhat.com> Date: Wed, 30 Nov 2016 20:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480107244-1484-6-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg01015.txt.bz2 On 11/25/2016 08:54 PM, Luis Machado wrote: > This fixes offender testcases that have test names starting with uppercase > when using gdb_test/mi_gdb_test in a multi-line construct. > > gdb/testsuite/ChangeLog > 2016-11-25 Luis Machado > > Fix test names starting with uppercase throughout the files. > > * gdb/testsuite/gdb.ada/array_return.exp Drop gdb/testsuite/. Otherwise LGTM. > diff --git a/gdb/testsuite/gdb.ada/array_return.exp b/gdb/testsuite/gdb.ada/array_return.exp > index f4dae48..37f2845 100644 > --- a/gdb/testsuite/gdb.ada/array_return.exp > +++ b/gdb/testsuite/gdb.ada/array_return.exp > @@ -52,7 +52,7 @@ gdb_test "break create_small_float_vector" \ > > gdb_test "cont" \ > "Breakpoint \[0-9\]+, pck.create_small \\(\\).*" \ > - "Continuing to Create_Small" > + "continuing to Create_Small" This looks like a good example showing why enforcing uppercase in the testsuite's internal routines would be going too far. I.e., it's quite reasonable to want to print the name of some random symbol from the test's source code which might want to be uppercase. > --- a/gdb/testsuite/gdb.base/testenv.exp > +++ b/gdb/testsuite/gdb.base/testenv.exp > @@ -49,7 +49,7 @@ gdb_breakpoint $bp_line > # First test with no TEST_GDB_VAR > gdb_test "continue" \ > ".*Program found 0 variables starting with TEST_GDB.*" \ > - "Test no TEST_GDB var" > + "test no TEST_GDB var" Another example. This time the name of an environment variable. Thanks, Pedro Alves