From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42926 invoked by alias); 16 Oct 2017 18:58:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42917 invoked by uid 89); 16 Oct 2017 18:58:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 18:58:08 +0000 Received: from ESESSHC020.ericsson.se (Unknown_Domain [153.88.183.78]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 71.8D.03220.E3105E95; Mon, 16 Oct 2017 20:58:06 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.78) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 16 Oct 2017 20:58:06 +0200 Received: from [142.133.49.59] (192.75.88.130) by DB4PR07MB314.eurprd07.prod.outlook.com (2a01:111:e400:982f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Mon, 16 Oct 2017 18:58:04 +0000 Subject: Re: [PATCH] Make native gdbserver boards no longer be "remote" (in DejaGnu terms) To: Pedro Alves , References: <1508178928-30820-1-git-send-email-palves@redhat.com> From: Simon Marchi Message-ID: <17a384d7-255b-e841-437f-6aa2ace2c2d6@ericsson.com> Date: Mon, 16 Oct 2017 18:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508178928-30820-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR16CA0015.namprd16.prod.outlook.com (2603:10b6:404:f5::25) To DB4PR07MB314.eurprd07.prod.outlook.com (2a01:111:e400:982f::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ee2ed30-bd1c-4a65-cf52-08d514c7d4ea X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603219)(201703131423075)(201703031133081)(201702281549075);SRVR:DB4PR07MB314; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB314;3:PtK0O1E3mzg3pE9ZZ9QPZrBcCH+6jPoSLYtQpBjgL+cMhA+nkEwY9a+VRvHf1cF9eFLG7UFs02lrMvr9dqpyjNRDxGWmERaYx07WB06c0Gy/+wVxt+H0+Rt1R+BIY1kP5TEUiwF/4kUjYO9yPAgcPhb506W/0IA3XvQoKTh5FVg7iEQ0jv/eIKN40yH7GNHRAWe+bXt/hp8l3P3rhjj4uvzkGjsc5l0TSVDxoP/VZO98BiRDj1DFgOg2I0vNmHnK;25:N86ipGpgBhRG9dBELbahJFadgRgyvHHIuFYGJdvSKLJX0i8jOnCUPfs8/5eO8zwwaX7YY+HIv/tYu4cTKuYV3r16ZTo9wP6UARf3i4ZfXf4zuI5wWph1vrKMm4NqE4JhkmqCgVQVcH9xmCXPVWLm5ivAroO0zC4IJ3/5pO9XmRuK4l8kQLhk84DePcZ82UUF9Enl/LCdwS9aqXBI2x6J5uIFA8x/w/+qi8dOBTQNaRW1qcHCD30kMyJnL/WO7Y138EzI4zk+QBe73a1hSCFFH2ya8cJyky5mfgvvEUK6cylAMTh3Hw9KHZP1NQVHbjs1ibShBPezbZwZuf2jM4pgXrYfEtGyVvUtF0aI9ajOXd0=;31:NdmLMzC57dUuUvViQBfirU+asEBfXcdUPaILExWPz/znCcfCZTX4xhrCheHCeftGynNxvCw9sgRS1y9HV0zxTh2hflQrTAlX6AHJOW5gfMifF4pAgYVt+vfx6rO2c8VTblcBDoTGAJEYZiRaW7KihVlNUKii+GrJ7JcgzFT3A+lDe4nEBeNMwEj5o4HHQ4B2Lcb7sC1alxLLBu6jq1AaBi8arqvVxbekgcRTkRgSm68= X-MS-TrafficTypeDiagnostic: DB4PR07MB314: X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB314;20:nLHFWMPBBX64ZqKsrBIEzKkjwdIwhC17cZgAf8jdBAXQPcfNSjPwm+/j5jRKyNQNVbGOaaRMIHC/4z95XrSdIhA6O5a6RQelByCy/p5t2N6Ifmhv6WFnV9KTatupWwOLTTB8yF99wZO8eCi/5ZqfaZRmtdbIqy8dos63HjRZDVaqbelSk8ybUunIvJ++qzWjA2LoxcJCC4eyFXnnBzerwDRonzqEW7B7z9dXHNVxRjCX7C/G8ReXNt2zwe/tElf7j6OFJG9snhGDKpes9tcsv258NKsSIcNDtnixlbg1QPVof16PkFO0fbKRa6ZY3IIGr8EZ/Wwj9+CsH/tKBRmZ5egbnKobqqId/U8VGKsq3cxtZ8dh8CTgjan6+UeJv97USpP+nt1NDTjxHGg5Q534JrQVuqhmwg/0VABZYaqCOBe0/UYey608H4HLzw0lzOZMvdrCi+0AbrBIourARDvsjixRGCiXHN4y0A1dAo/DNzmaxxu/gZBUQdo9tWc06N6l;4:MeWKJyJOa+9hV8qU9kSYIDcNjddfc3i8bnciqyncpdRpDJWjv3P/XyfxrMnQazN6hcovRWuqCuCO130dcjGv1O5Gxyqi/7iBYA/dm/DnPuIPcWwnsBI7YkPgOzB3SRDvL7TONS/gK+nseb0ECwPP5CBT+iovGDr4RnrpF2I1XszfS/VsnHtJ+40oXpHRh49CDtAXTNmRoqP0WvnTaOP01G+Ks5lvEfijMMIYOh4ZQWod9cxcdQUuUpjYPzbroowz X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB314;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB314; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(52314003)(377424004)(199003)(24454002)(189002)(377454003)(83506001)(16526018)(53936002)(16576012)(2950100002)(189998001)(49976008)(23676002)(478600001)(58126008)(316002)(33646002)(65956001)(6116002)(97736004)(106356001)(65806001)(2906002)(8936002)(66066001)(25786009)(105586002)(47776003)(230700001)(3846002)(4001150100001)(53546010)(229853002)(86362001)(81156014)(8676002)(101416001)(68736007)(64126003)(31696002)(31686004)(50986999)(6486002)(76176999)(54356999)(81166006)(305945005)(5660300001)(65826007)(6246003)(50466002)(7736002)(6666003)(36756003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB314;H:[142.133.49.59];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTQ7MjM6ZlB6cjhNZVg3TXhuM01HczNmeitOR3lLUjdI?= =?utf-8?B?VjJVcW5BRnZ5bGVFNGRBQ1NPVVFBWWRDYzkxSnVrb0pEdmt5dnhkdmVUUzJS?= =?utf-8?B?VUUrWlMzWHhBWEFtcVhTd0I1OEFRRDY2bSt1anZtckNoSTRwWkl4Rk11N2p1?= =?utf-8?B?TEE0TkE0ZnhtVy9Qd1NRRTVYSEQxdHB0NE5DT3MweVZ3d0V2V0x2YVJWMUgy?= =?utf-8?B?Yld4UFV3NVMrQU15VTJNcFJqM2hjaGNRNXlRMXVCTURobmhqK2RxenZmNnJ4?= =?utf-8?B?ZHNmcGZ1dnV2cTBtQk11Nm9IVHNKSnJTVUlqT3dobDhhNDhCNDZhdlFsTWtV?= =?utf-8?B?c1J0cnpFa1VKdE1vb1lYSjhhbjBWYWpoRUlrWjBES21oQm51QnNBczFsMkt1?= =?utf-8?B?Q1ZiYUh3aHpvU2pxdlNFc3NOQ2RtNmVtN0dtaGU2MmJzV1d3YjU2TmZBZjVS?= =?utf-8?B?RlBlWEk5aWpTL3NLTkdqUXFTYXhLMC8wWko1OVZnWFRBd0k2eWVyMXZMaE5R?= =?utf-8?B?aUcxK3ZDL3BCN1EvbFVyb2Vza0p5RmFvTU1wT2xBRXl3MCtOaWxsVXNnYXpI?= =?utf-8?B?S2twTWhWOVlDNkZXVUtacExOMkZPaEhEUERQR2IwYno0VlcxckZBSzBxR3Yr?= =?utf-8?B?WElnNUtzTVBnMnZQeUFLSVMzRHJyN3ZtbkcvYTZ3QmVTSEhmZ1I4anpJZlVr?= =?utf-8?B?ZUJuQ2FBMXV1L3NFZmxGSDJNSW1YcEwxUlVRY2taUjgvY0JZQnNOR0o5Qkpv?= =?utf-8?B?d2pLZkJEODdpZUJUREdyZzN4cTByZzNBVS9BZGprTDNuazFOZjFRa1dYeWpa?= =?utf-8?B?QkZPMW9YSzRndVF1SVhVUTl2SlZLSW9SUno4eVdMUURhM1B3bVVCa083UXJJ?= =?utf-8?B?S0d4WkNCbnhiaXY4TlhFcjgzMCtqczcxbUd3S0RpeUdSVFFjWGhkMVpBTDJ3?= =?utf-8?B?Y0RzSDRPVjBKdUxPS2tRWUlLNXRiQ2FSRVlKU3UwcFlsQTc0SEJZbkV0NlNH?= =?utf-8?B?WE5EZ1lTQ2JuUWl4YTBtRmdVaU9CTlQyV1VvekZTcWYwUml4bnBPOElRdUJv?= =?utf-8?B?dCtLQjAyMWhHcGRIeCt2cVFEV1VSdFIvMzdNcCtLcjdHOUcxTFgya0lDRzNx?= =?utf-8?B?MnR2RW9PZUFVaFNsTHBFV2FTVmtiek94Y1Z4VHZaMnpSSzRZMFRQckdldTBs?= =?utf-8?B?YWtQblVTalQ1V3JWYlRDdlVjekRJMm1KSmFaaEVEOW16ckZJcUpJWTJCRXFB?= =?utf-8?B?R2crU3hlalhFeWZ5KzhyRVYzUnJ4ZGtheEt6STVlaUREdG1qM2l3b3YydS9K?= =?utf-8?B?dmZpRTI3YW01U1E3RHRQN3JYdFpLZVJPaXdHaHdBTWY1dkpKUzVSbWZQOG1O?= =?utf-8?B?QUl6ZXdMd244MzRwdUZvdEFTeUs0a1ZwNGdzbERPTGJmYXJXVHVSV0RXMGFB?= =?utf-8?B?S1Q1Z2dKaEEvWkU4SUlGM0tXTnBrNS9DL3ZTK1RYYkhSbEZmK1hnbVdCKzZN?= =?utf-8?B?Wit2dWtmd2dMV2MzdUN0Z3BjaUk4cVBkNk96c1dmbk9UOElxNVRUMVBRVG5R?= =?utf-8?B?YlpZRkxHMVpMeEN4VG13clVqd1pvZU9QMHZzMzl3TGhIMkRLdnpSMmZqK0x3?= =?utf-8?B?U01HNy9KUmgzWnBJMzZ6L1Uwd2Z4eVQwOWJVdXZqcTM5b0JzdXArS2xhQk9X?= =?utf-8?B?U0dWWXF1OU85RWtKVEVCckR3OVR3UjVWRng1TWg3aUFmaWhabTB5MURmQStZ?= =?utf-8?B?b1RURDc2WHZHYnNSdCtIUDJjSzVwbkZ4MGs3RzdNVDFkRXpVNHVYaloyVTFv?= =?utf-8?B?cFhSTVhsOTBFbDlzN2ZMY0pUT25CRFNJWE8yLyt0TFZVbU9OWEc1MW1tTWk2?= =?utf-8?B?TzNnQ3dUVFcyWVZFR21RMUc3R2o3Vm9BczFFRTBpYlkyNFlmYXZkWDJNYWVi?= =?utf-8?B?bEc3ZFhGSlE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB314;6:4sC/MdOp1a6VaPRhC0+hRRnlnFYJPu1vDJvBa/lmwwljUmDxqTtxGWZdowTc3ZQTawvy9pAwLR3koCGpcV9u0fx1R8w3cUFzAiTnSZqCPquXDE7cGYNGReges+wRfQ3wXwdkmDKlq2yE45MuY5oa4jKp6z6Jzcn/lJ/AKH0+N2VDqmhDzhRkddmoaX9JwCy7kNc5bb85vTJMAe0Qaa4GVzAPkyr3SHN5nQdcQNzPT7lr+i91ByvD/zFON+66E5XeQFlmsPOrJOQGs/wTMVzEa0vvTZz1kSMzXzYd3J4uq5BxE5KByLdD6MKRuy3dVdS0T14W5CEsd9mY1dsHrON8nw==;5:5nkc8ui/0+iUnUHkQ6aGvUx2QHQyLM1oXtru9MD3yfSOPh2xcihbGDDAo6V1Umk2oJYyWUFK4PU7iz+TAWHwyh3Fz62jeUubr/tewx1XLiuvcrquyPGNOUxu1FmSmiuel8tgH5k/VlzgmDN4hYe2KA==;24:x63pbRWSDBBeALpOPaTxaRa4dELhJKr0eStMYMWr0S8z294tF2HgJqOJK861fGaSZ+EZIyCJjz3lLO7/YscnpBAXrrZduQhyzI3CVCklDoc=;7:34wixGlUgF8GGu8Lr243445iCvLISmQP7jO7WKb/YkHQEN4B8YDYCtBXlv6dO6aBcdEAMEYPjcya541VTu5YiIi295KNDUcMEoNYz+Jv+at1PH8HjCClJmaYjhJPNLiluyTljGZBW4SQd+eQ5yy08hUdW+WEpVN4LJjF82kCROjOJeiM6/xr30PxVIFEEAXdQg8nfUruYABbIm7GBx846Uls3E4N7UC48Iq3CyB0onM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 18:58:04.0530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB314 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00459.txt.bz2 On 2017-10-16 02:35 PM, Pedro Alves wrote: > This commit finally clears the "isremote" flag in the native-gdbserver > and native-stdio-gdbserver boards. The goal is to make all "native" > boards be considered not remote in DejaGnu terms, like the > native-extended-gdbserver board is too. > > DejaGnu automatically considers boards remote if their names don't > match the local hostname. That means that native-gdbserver and > native-extended-gdbserver are considered remote by default by DejaGnu, > even though they run locally. native-extended-gdbserver, however, > overrides its isremote flag to force it to be not remote. So we are > in that weird state where native-gdbserver is considered remote, and > native-extended-gdbserver is considered not remote. > > A recent set of commits fixed all the problems (and some more) exposed > by testing with --target_board=native-gdbserver and > --target_board=native-stdio-gdbserver with isremote forced off on > x86-64 GNU/Linux. I believe we're good to go now. > > The native-stdio-gdbserver.exp/remote-stdio-gdbserver.exp boards > required deep non-obvious modifications unfortunately... The problem > is that if a board is not remote, then DejaGnu doesn't call > ${board}_spawn / ${board}_exec at all, and the > native-stdio-gdbserver.exp board relies on those procedures being > called. To fix that, this commit redesigns how the stdio boards hook > into the testing framework to spawn gdbserver. IMO, this is a good > change anyway, because the way its done currently is a bit of a hack, > and the result turns out to be simpler, even. With this commit, they > now no longer load the "gdbserver" generic config, and hook at the > mi_gdb_target_load/gdb_reload level instead, making them more like > traditional board files. > > To share code between native-stdio-gdbserver.exp and > remote-stdio-gdbserver.exp, a new shared stdio-gdbserver-base.exp file > is created. > > Instead of having each native board clear isremote manually, boards > source the new "local-base.exp" file. > > Simon, I've migrated the text you had in the commit log of your > version of this change to the testsuite/README file, so that we can > refer to it. WDYT? That looks fine to me. Good idea to put that in the README, it will be easier to refer people to it. I didn't test remote-stdio-gdbserver though, but I did test native-stdio-gdbserver. Thanks for doing this! Simon