From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74521 invoked by alias); 6 Apr 2018 18:20:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74169 invoked by uid 89); 6 Apr 2018 18:20:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=integrate, Marchi, marchi X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Apr 2018 18:20:42 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6DCE42636C0; Fri, 6 Apr 2018 18:20:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52E4084432; Fri, 6 Apr 2018 18:20:40 +0000 (UTC) Subject: Re: [PATCH v2 5/5] Adapt and integrate string_view tests To: Simon Marchi , gdb-patches@sourceware.org References: <20180330214647.485-1-simon.marchi@polymtl.ca> <20180330214647.485-5-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <17975722-e9f3-98d8-3187-4eb9649dac28@redhat.com> Date: Fri, 06 Apr 2018 18:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180330214647.485-5-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00098.txt.bz2 On 03/30/2018 10:46 PM, Simon Marchi wrote: > - try > + > + bool threw = false; > + TRY > { > str01.at(csz01); > VERIFY( false ); // Should not get here, as exception thrown. > } > - catch (std::out_of_range& fail) > - { > - VERIFY( true ); > - } > - catch (...) > + CATCH (ex, RETURN_MASK_ALL) Do we really need to replace the try/catch with TRY/CATCH? The latter must be used throughout GDB because the code inside the try statement can use cleanups, but here nothing is ever going to use cleanups. > + > +/* The actual tests live in separate files, which were originally > + copied over from libstdc++'s testsuite. To preserve the structure > + and help with comparison with the original tests, the file names > + have been preserved, and only minimal modification was done to have > + them compile against gdb::optional instead of std::optional: > + > + - std::optional->gdb:optional, etc. > + - ATTRIBUTE_UNUSED in a few places > + - wrap each file in a namespace so they can all be compiled as a > + single unit. > + - libstdc++'s license and formatting style was preserved. copy/pasto, optional->string_view. :-) Thanks, Pedro Alves