Re: [RFC] -thread-select double print stack frame

Daniel Jacobowitz
2007-03-28T11:43:01Z

On Wed, Mar 28, 2007 at 05:53:15PM +1200, Nick Roberts wrote:
> I was looking specifically at this clause in print_source_lines_base:
>
> if (desc < 0)

Right, that's where it comes from.

> I think this code may only be reached when there is duplicated MI output.

I don't know. Some of the source-related commands may also call
print_source_lines, in which case they'll get here too - without a
frame printout.

> > This does make me wonder about the patch though. Denis, could you
> > hold off on committing it? Which duplicate copy are you eliminating?
> > Maybe we should diff two testsuite runs to see what else changes.
>
> No, I think this change is alright (I haven't run the testsuite though.).

You're right, anyway. That's what I get for reviewing patches while
I'm so tired. I was worried that the copy inside the frame={} tuple
was being eliminated by this change, but that's definitely not what
happens. Only -thread-select of everything in our testsuite changed.

On Wed, Mar 28, 2007 at 10:25:37AM +0200, Denis PILAT wrote:
> I do run the testsuite on i386-linux native target, no regression at all.
> Can I commit or not ?

Yes, go ahead. Thanks.

--
Daniel Jacobowitz
CodeSourcery