From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>,
Denis PILAT <denis.pilat@st.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] -thread-info new command
Date: Wed, 21 Mar 2007 21:09:00 -0000 [thread overview]
Message-ID: <17921.40699.742164.983281@kahikatea.snap.net.nz> (raw)
In-Reply-To: <17919.21588.93918.661753@kahikatea.snap.net.nz>
> but I could only come up with:
>
> http://sourceware.org/ml/gdb-patches/2006-11/msg00208.html
>
> which didn't seem that simple and is probably not correct
I've gone through the archives to try to understand the changes. The above
message says:
Well we need to propagate the error message back to
captured_mi_execute_command.
Actually there are currently two ways to catch an error in MI:
1) Using error () and catch_exception.
2) Using MI_CMD_ERROR and mi_error_message.
The first gets caught in mi_execute_command and the error message is stored
in result.message. The second goes back to captured_mi_execute_command and
the error message is manually stored in mi_error_message.
I think that only one method should be used and this should be the first one.
It appears that catch_exceptions_with_msg was used to avoid using
error_last_message () but this was no longer needed when mi_execute_command was
changed to use catch_exception instead of catch_exceptions (the comment "Can
this use of catch_exceptions..." is an anachronism). The error message should
be available in result.message for these functions (gdb_thread_select,
gdb_breakpoint,..) anyway.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2007-03-21 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 14:30 Denis PILAT
2007-03-20 1:44 ` Nick Roberts
2007-03-20 3:09 ` Nick Roberts
2007-03-20 3:14 ` Daniel Jacobowitz
2007-03-20 3:26 ` Nick Roberts
2007-03-21 21:09 ` Nick Roberts [this message]
2007-03-22 4:35 ` [RFC] gdb_breakpoint " Nick Roberts
2007-03-27 19:54 ` Daniel Jacobowitz
2007-03-27 21:36 ` Nick Roberts
2007-04-04 14:36 ` Denis PILAT
2007-04-10 15:14 ` Daniel Jacobowitz
2007-04-10 14:53 ` Daniel Jacobowitz
2007-04-10 21:54 ` Nick Roberts
2007-04-10 22:04 ` Daniel Jacobowitz
2007-04-11 1:16 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17921.40699.742164.983281@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=denis.pilat@st.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox