From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25668 invoked by alias); 9 Feb 2007 20:48:38 -0000 Received: (qmail 25594 invoked by uid 22791); 9 Feb 2007 20:48:38 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Feb 2007 20:48:32 +0000 Received: from kahikatea.snap.net.nz (30.61.255.123.dynamic.snap.net.nz [123.255.61.30]) by viper.snap.net.nz (Postfix) with ESMTP id D037F3D82C4; Sat, 10 Feb 2007 09:48:28 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 2E2644F70D; Sat, 10 Feb 2007 09:48:25 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17868.56856.625440.923769@kahikatea.snap.net.nz> Date: Fri, 09 Feb 2007 20:48:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Subject: Re: -var-create testsuite updates In-Reply-To: <20070209162019.GA14230@nevyn.them.org> References: <20070209162019.GA14230@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.93.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00149.txt.bz2 > I noticed this today, which I should have thought of earlier: > > -mi_gdb_test "-var-create func * func" \ > - "\\^done,name=\"func\",numchild=\"0\",type=\"void \\(\\*\\)\\((void|)\\)\"" \ > - "create local variable func" > +mi_create_varobj func func "create local variable func" > > The old tests were deliberately checking that the varobj was created with > the correct type, and the new ones aren't :-( (Groan) I picked up the tests which were designed to fail but changed the others by autopilot. I'll work my way through the changes to work out how many others we should have kept and submit a new patch. -- Nick http://www.inet.net.nz/~nickrob