Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Catch errors in value_get_print_value
Date: Fri, 09 Feb 2007 02:21:00 -0000	[thread overview]
Message-ID: <17867.55937.642747.250390@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20070208222519.GA2611@nevyn.them.org>

 > > It's much quieter than a window full of error/warning messages.  If
 > > there's no value available, the frontend doesn't show one.  That seems
 > > logical to me but perhaps only because I'm used to it.
 > 
 > Well, maybe we could use in_scope="false" and no value, and let the
 > front end decide...

But the variable may be in scope and the frontend wouldn't be able to
distinguish between this case and when the variable really was out of
scope.  Maybe another value e.g in_scope="unreadable" would work.

Re your patch:

  if (initial && changeable)
    ...
  else if (changeable)
    ...

Isn't:

if (changeable)
  {
    if (initial)
      ...
    else
      ...
  }

easier to read?


-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2007-02-09  2:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-01 20:51 Nick Roberts
2007-02-08 17:41 ` Daniel Jacobowitz
2007-02-08 22:19   ` Nick Roberts
2007-02-08 22:25     ` Daniel Jacobowitz
2007-02-09  2:21       ` Nick Roberts [this message]
2007-02-09  2:26         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17867.55937.642747.250390@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox