From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25579 invoked by alias); 8 Feb 2007 20:44:03 -0000 Received: (qmail 25564 invoked by uid 22791); 8 Feb 2007 20:44:02 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Feb 2007 20:43:56 +0000 Received: from kahikatea.snap.net.nz (145.62.255.123.dynamic.snap.net.nz [123.255.62.145]) by viper.snap.net.nz (Postfix) with ESMTP id 698B53DA8FE; Fri, 9 Feb 2007 09:43:49 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 7E7974F71B; Fri, 9 Feb 2007 09:43:48 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17867.35715.219790.51000@kahikatea.snap.net.nz> Date: Thu, 08 Feb 2007 20:44:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Add value field to output of -var-create In-Reply-To: <20070208202450.GA27835@nevyn.them.org> References: <17818.12006.696879.216415@kahikatea.snap.net.nz> <20070105150747.GD24554@nevyn.them.org> <17839.14615.772612.987502@kahikatea.snap.net.nz> <20070120190903.GA22153@nevyn.them.org> <17842.36650.58436.387233@kahikatea.snap.net.nz> <17860.5394.631978.403208@kahikatea.snap.net.nz> <20070204140955.GA8764@nevyn.them.org> <17862.21280.730210.678232@kahikatea.snap.net.nz> <20070208175749.GA17845@nevyn.them.org> <17867.33519.93541.517510@kahikatea.snap.net.nz> <20070208202450.GA27835@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.93.8 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00100.txt.bz2 > > It doesn't display properly in Emacs without a * on each line e.g look at > > this change in Emacs: > > Yours doesn't look right in emacs either; spaces instead of tabs > disables the highlighting, and the old date. I fixed it. Thanks, I also had two entries for gdb792.exp. > > I kept the *'s but removed the commas. This style is used by the Emacs > > project, at least. The convention used there is that if different files > > have different changes then a blank line is left between the ChangeLog entries, > > but if the changes are the same then the entries are contiguous. > > I really don't care enough about changelog formatting to argue about > it. But I will observe one thing: this is GDB, not Emacs, and it's > always more polite to match the style of the file you are changing. > Emacs seems split about 50-50. The file is already inconsistent (some entries use "Ditto." or "Likewise."). I don't see why the font-locking doesn't work in Emacs as it should match up to the colon. I'll see if I can get this to work and then I'll match my entry to yours. -- Nick http://www.inet.net.nz/~nickrob