From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47519-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21884 invoked by alias); 4 Feb 2007 21:46:28 -0000
Received: (qmail 21874 invoked by uid 22791); 4 Feb 2007 21:46:27 -0000
X-Spam-Check-By: sourceware.org
Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 04 Feb 2007 21:46:22 +0000
Received: from kahikatea.snap.net.nz (84.60.255.123.dynamic.snap.net.nz [123.255.60.84]) 	by viper.snap.net.nz (Postfix) with ESMTP id 0EBBB3D83C3; 	Mon,  5 Feb 2007 10:46:19 +1300 (NZDT)
Received: by kahikatea.snap.net.nz (Postfix, from userid 500) 	id 96E954F703; Mon,  5 Feb 2007 10:46:17 +1300 (NZDT)
From: Nick Roberts <nickrob@snap.net.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17862.21544.94445.730463@kahikatea.snap.net.nz>
Date: Sun, 04 Feb 2007 21:46:00 -0000
To: Daniel Jacobowitz <drow@false.org>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb-patches@sources.redhat.com
Subject: Re: MI: type prefixes for values [PATCH]
In-Reply-To: <20070204141613.GB8764@nevyn.them.org>
References: <20060317191207.GA19068@nevyn.them.org> 	<dvliph$urc$1@sea.gmane.org> 	<20060324030332.GB2853@nevyn.them.org> 	<e00anu$f6m$1@sea.gmane.org> 	<20060324202056.GA26748@nevyn.them.org> 	<e12k8s$dci$1@sea.gmane.org> 	<e2scu2$vvn$1@sea.gmane.org> 	<20060505192535.GM31029@nevyn.them.org> 	<20060515165354.GG28924@nevyn.them.org> 	<17860.7702.941611.6892@kahikatea.snap.net.nz> 	<20070204141613.GB8764@nevyn.them.org>
X-Mailer: VM 7.19 under Emacs 22.0.93.5
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-02/txt/msg00039.txt.bz2

 > Sorry about losing this.  The patch is OK; if you have a chance to add
 > a test for printing references, that would be nice too.

It might have been me who didn't follow up.  I'll submit a test .

 > > !  	      struct value *val;
 > > !  	      if (values != PRINT_NO_VALUES)
 > 
 > Looks like you added a space before the tab on that line?  Please fix
 > before commit.  Thanks.

Committed.  I've tried to remove the space(s).

-- 
Nick                                           http://www.inet.net.nz/~nickrob