From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21175 invoked by alias); 4 Feb 2007 21:42:19 -0000 Received: (qmail 21111 invoked by uid 22791); 4 Feb 2007 21:42:17 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 04 Feb 2007 21:42:10 +0000 Received: from kahikatea.snap.net.nz (84.60.255.123.dynamic.snap.net.nz [123.255.60.84]) by viper.snap.net.nz (Postfix) with ESMTP id 4FA0A3D828E; Mon, 5 Feb 2007 10:42:00 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 206204F703; Mon, 5 Feb 2007 10:41:55 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="+HaukhVL0H" Content-Transfer-Encoding: 7bit Message-ID: <17862.21280.730210.678232@kahikatea.snap.net.nz> Date: Sun, 04 Feb 2007 21:42:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Add value field to output of -var-create In-Reply-To: <20070204140955.GA8764@nevyn.them.org> References: <17818.12006.696879.216415@kahikatea.snap.net.nz> <20070105150747.GD24554@nevyn.them.org> <17839.14615.772612.987502@kahikatea.snap.net.nz> <20070120190903.GA22153@nevyn.them.org> <17842.36650.58436.387233@kahikatea.snap.net.nz> <17860.5394.631978.403208@kahikatea.snap.net.nz> <20070204140955.GA8764@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.93.5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00038.txt.bz2 --+HaukhVL0H Content-Type: text/plain; charset=us-ascii Content-Description: message body and .signature Content-Transfer-Encoding: 7bit Content-length: 1636 > Could you please post a full patch, including changelog? I'm finding > that when you update just bits of a patch in each message, it is > virtually impossible for me to find all of the current pieces. I think > this patch will be fine, though. Sure. The code change is just one line (below). The testsuite changes are in the attachment. -- Nick http://www.inet.net.nz/~nickrob 2007-02-05 Nick Roberts * mi/mi-cmd-var.c (mi_cmd_var_create): Add value field. 2007-02-05 Nick Roberts * gdb.mi/mi-var-block.exp, gdb.mi/mi2-var-block.exp, * gdb.mi/mi-var-child.exp, gdb.mi/mi2-var-child.exp, * gdb.mi/mi-var-child-f.exp, gdb.mi/mi-var-cmd.exp, * gdb.mi/mi2-var-cmd.exp, gdb.mi/mi-var-display.exp, * gdb.mi/mi2-var-display.exp, gdb.mi/gdb701.exp, * gdb.mi/gdb792.exp, gdb.mi/gdb792.exp, * lib/mi-support.exp: Update tests to include value field in output of -var-create. *** mi-cmd-var.c 10 Jan 2007 11:56:57 +1300 1.28 --- mi-cmd-var.c 18 Jan 2007 17:26:48 +1300 *************** mi_cmd_var_create (char *command, char * *** 125,131 **** if (var == NULL) error (_("mi_cmd_var_create: unable to create variable object")); ! print_varobj (var, PRINT_NO_VALUES, 0 /* don't print expression */); do_cleanups (old_cleanups); return MI_CMD_DONE; --- 125,131 ---- if (var == NULL) error (_("mi_cmd_var_create: unable to create variable object")); ! print_varobj (var, PRINT_ALL_VALUES, 0 /* don't print expression */); do_cleanups (old_cleanups); return MI_CMD_DONE; --+HaukhVL0H Content-Type: application/octet-stream Content-Description: Update tests to include value field in output of -var-create. Content-Disposition: attachment; filename="testsuite2.diff.gz" Content-Transfer-Encoding: base64 Content-length: 6763 H4sICEJRxkUAA3Rlc3RzdWl0ZTIuZGlmZgDtXX2P27jR/zv5FDzf4pC4sqJ3 W1ukfdK0V1yBK4q2QAucW0OWtbt6zpYESd7kus1375DUGyW+yOt9yeW0ydpa kRrODH8cjmYo6rtkF328RNe7rX6I3xzixW2QL7b7NPxRjz5mL9+e//Pyr+// hq7ifXSJ3oS3xZsiD8kvNPmmjIqyOMZl9EbAgHb7Mo/KPI5u4+Qa5fBVxGmC TN20X+7iqyu0CNEiQ4scn0ED9ufzuUi0Fz76U5AgyzCWyFxeuv4lEFgY8POC UF8sFsJLHfRttKWXWualbV/aHr0UN9j9AY42+TEpU7RLN+T6DRGZMOY4mmsh XO0lQvD/a/R3KLtE4QZai4PtPlrYukUKfh8VIRTkUVBGKNyiINmhqzR9+RVu ALgkVNGMsNnWmsPHDK2h1ovZev3vXZpEWhIcorfrWbhdz7TkeAhv4v0O/jbg z/KnDBfFSbme1ZdVxIDzYI9qtjBZyrKwdWAOmodPTAgBoW/WM6gcHnZYuA2t dYmOCaEH+qmua5pIt/8fheUafpL1TJ8D+1Gep7l2KK7f3o8UkQn3Kta7geBo cZ7e6Wl8EbSAS+H/F6cwDqB7AuyifUQFqOojz9OWjgrY9lDBCkQzKuJgGkrO ATUmXPNblFGGNYNpWugtMi371zPafbhog4vYET1DQH5GuD3s9LDGmudoSyXW ZKpgQYZVgH+fSgRO74+6mMBgtdJ8TwUDdyh7nCRRjghtFSRI1Y0KGE2tc+DR EBFq2LgfRFaO5ishMlZNLFxa9UhA8yiCnQUc39dMmFoVyPG4o8ZSWBCLIsUS 2xDrTCNizSRML7tM30TQdeVNUKL0WEJf4k6KE1SEaRaRqYZ2MT4NFVB6RYsI anxb830VaqQqGlgWi348p2Tf9bxR69ndUWukP+r23VEXDdln3FHrBH/UZd3R /qUP5I+6mmtP/ujT+6Ogd3PyRx/RH11qS3fyR4k/6mpLJda+VH/U13ylVzH5 oytX85UQ+UX5o6ZhgEO6mhxSqUPqgI6U9zE/e4+U9h7uiueMjzYMCP1Ry+w7 pJaJBuzPB/HRpuyFaaB3x2vsVXrIcC+t5SVQqB1SID8MkLbXDhxSxxA7pNHH KIQ+IWMRHy+S6GMJYzBKdgs8SDMQbUFYdV3NU3ioDs9TaiAzK8r8GJabXRTu gzwoQVfFTDZAOfVhvPKo8IcvpyY7mk2zHc60Mtp0LlINb648Yt0wMzvmII8S gvUhGdK/WOGWfEzfW+HsaOcpmncOKwP/PL0+JFMIzCD11XQSQXefEDi9F3cw kClyPVtzwfNSYHdlDnXZk3D2IYrznRS0pAbAlNbkA5OUiaFIiisgovV6rsJh xZREMkuganIlBZtnaa63UsHtVB2xOKO6oZ+PJIv6FiVOrtIFaH7RXIyvpPcq 1hJsnOJuxdF9Y6gE0vriN+AUbLIyx79KkDC1a8QwJ2XwYSr2sMQ4KQRBI0HE ti5TgSnrBVYP5NbHckCzCs/2NM1yoMVqlHNKYcAeTwdjZl7iaTs2M/lW9062 5hsK++XqJkd5WZFki9+EN4ESkr2qgMfeGQEY2UpCIOIKNRJH4bHfukxwUUf0 pCc3WHAjuvI9ORDH65IFYU+FvT8V4HsEge9jDDEJgjrf8+CWXZFKBF58kab2 aXI9EnV11RZ19Rkp6upKQtThCqhjA09BXsOBRHjLkHZEowFyj+aZmq+aYcfr k4e8Ro29P8ch7yEFPgt5pmHbcD/rKC2eLRylwEMxAne4Wos5/JcUb7gCizVb eAORbLIUkBdVVm/9gw0f/xqJPcKJTHC5ASDSY8yZBng0WJ0q1I3RJA9xRIGd w8cX66w7AdMyDQ0+msz41+gfNz/BhVGBypu4QDfBbYQC9O13//z+D7+F8iIq j9nm41UQ79F8Af+4YftjtsNCz+u+JZfXCAJrnFxH+7go32IYrO8GkNINHd91 6x1zFicbEgKBegCnqELZhtLCwLsK9gWcXn/CqKrTBBUfwZ6ovu4YTLtjDF7h gIvZNPYaVURxx4T7CKYOVlwKJMuwQHFGY74+d8U9j6r4KdTnjFhZI0NWTj9i 5aAh+/NhCnVkyMrh5VBlIStnRA6VHez0Vt/UXH8KUj1hkAoUrowaTEEq7tR0 p88JkChyXV9zPUWK7JcepHJXoCPnlx6kskkoZQpSPXyQytA8azkFqe4VpPJc bbVUJIimINW4IJVnaqsRoYIpSOXbK813FAudpyDV+CCVbYM+FSsJpiAVXZfi aqZhKi3eFKRSBKl8suTcUMbknzJG9RU6UzDx0pXF1bMvXqEsnBYLGAgw5y9f oaUvTKuzohpu6b1LyxBFAwYXnxQOwGNnnwY7dHG3hfEK6vhEeIOZgZkYmsjB 9++++/Nmg09Kxl6Q58FPMOrI96w1Tr0hR4qFow0PrWsyuF5Z2sK8NNfr1/Xg kpg62mbDdY9BHBBr7dFiEez3cH5/jIqWWdRjluWuvpiE1aqCu65A+gJPT9AT cIIcdgjgBXGkOTjG11vUYvBEJtKuP2ncJoymBeNxGmhFOFuCOnCIUYth1b0D FcGKtUSzqmua76nnf1Y9zzfnh+ddh3hQrEIc2HGrNeQH4RpEWiJ9IsbiGvCD KJbrnm68XQuHFSvjXU+16D0dNNf7dNsZNZzhYppm15jTCzZFfMhgkM3Zv2tf B67pGXemGoskr+NSkeIyTahlR63b1ONT7CuBRml8y+oEUz9Tqevxo88fXAUc fDSxfmIoi06kf+lopuO3EOFQdFRhwELhBOxrizBvDgWud118zmrxpgkVV1mH rUzBV8ZljBN8UzHXNIR9Yxl3+MY+CEvKXvOHiL+mglBzuIaCu06bSvYyhr9M yWAm4JAXNlLqsG1NxSYJCszpt4g1XCZUWx1VUDJFWlBqreYnkzGUDTkSxTmU qhrF1hXMHSVmixyI2CKFQkVVpQp+aANKNTUMZVKOMg5LZo+lcWoax9cuPW7J HFAdifiipUJV1cUKpqo2lMpqucrkbGU8vsw+X+MUNpK5Ztbcs/NlnzWVc1DH W0i1KuyiZLJqUqnAlslMzmV2HzbH6XMcr1fHJMTPWsGX6FkrKBIC7zaNd9gt J1Gq13DwCp/57+vO/bTwGSzcpMTt4DxMV+lfb6z1CKTozLTSPydHj37fSXDQ jEROzsNfdeeRLBCe20fI2dRtxWxOyaVsqp3mI/XbkIjIPHPGaGi8fPpAPH2U dPrDCCeJO5o6J+iOiSPMCbl/wD6x6bU3EOf5xGwEo/GFmwOlG/sVn1DjvrZH 453OHq121HV9QAE1jvfVZ61DL1MT5PlzPYrE6aGf4xywPkeUQCalkElJUG+i +lL4N4K+r/ya+nusN9KjUk3T9fdY96HPS00mU9AZTPU9QtXsWX+PnYz77NRk MgWdwUzJEiIzJPl49ImMq4fOBDY888gzDpehdqYZnHjEyYGvmx4n+jmMSK24 OiXZXTKLaziGrTlmsxyonZ/6y2c7i1+DooivE1RAi4jEc/AD/gR7ryj516oY BAm0Vsnw5lgwQzblJ8cgetGjTkuiEHklWcseObJqwWvO6iDWxU30sd0Lxl4a mr1s5s8HVyWLrR6P5OgZBOcgLkyTMk6OZNVPcdzm6RH+jEwKN9vRHNWCC4u7 NKW1ZGlOjVuBYm1PdgLotCLb4QMB3GLRxh4nuV6x8u4Ke4Ain++eMQ6xWbB6 y2XoBb24ZzUj9PRFkOv7mmMoVq6d3yssgGP4x1Fnz4LCv8eVX20yq02J9rXJ dJeu5q4ak9lDPDRaZFEYB/sq2izfq6kA4jAT7jYB+j8U1Lnduy5gZm2dDm5m RoUajM/Zpyp3NxuQbYd8l8s4CfNNQLMGtqe5TrNTwDOKM8wNnCPb6LmwQ6/u Yd/VPINdmvMO3darMBF5agNaAn52aHfMceaMoXiTHvc7tI0Q8FXEuyiPdoRI d3sSXWY+kuN+X82P87nRpvxZTda1pLBg1wo0lzRywQ3EB/oQDrHXYRhFOw3F VyjY7fKoKNB/ohyUWhBp8WjTULAvQcLrGxSXhMaHeL9HSVoiIsgHvFNLDN9B gQ5RANasTHWEvk+hDPycNC/xOdwervjH3/+uWpwNMOxtWPFYOmdtTKvrufF5 60kK6R+BeLNrGlmK3GRACXK+ITXW6wSPL4KiemAhejHK8vQ6Dw6gQzDmEYqS HWhI5crRWoDTDRx1gPqKQWpFi4dTfT777zfw2ewhBycwh+2Wc7jK6yGUO/wJ OwiUHJU34GrDR+VgMT10TNrjNCd0DjH4Qsm1tCfok2u4J8M8KG50iuClD/OC WyP4YZTOQrVSNlb1Z6kGwQNsz7bQgWlfuNJh1V/osEJ91uecR9dGrHRYcZ9b E650kOz8Oa10mFY6TCsdppUO00qHaaXDtNJhWukwrXSYVjpMKx2mlQ7TSodp pcO00mFa6TCtdJhWOvzCVzp0c0CzTopvRsIgtr/UHEOxudOUeX7qzLPnaPZS sU35lHmu85L2SnMd54vJPBum5rbLDr6YzDP3ac9dXGT74KfnfOKzw4L43bze 4N28HuKIMB88+dkplb+f1+M8/dm9eJgXWQnyIhgJcAX0CbqjeU9XU+0h5Omc 8drYkm0gvffZkkwnfArs6zY4K7C9DSQTosfsg0dmwvSK5XzkW6JGqoC1h1h0 /PtIrI82hpXycR3T9DXTUux553ENdGfyeNj3hJ2eMOi+LYnHvVR1mH2ywaq5 BFUo9ukdq4qevz3+PWH3Yn90z3feCmcuoedXyp63ZOLSLfrwFq31tgYyIDzz loeq3RwatrqrNft8yLZvIAQ6sRm6AcKoWM1wHwVKrBuso+TGhu8aikOC1ULg lt64HdmETJLdnIgYFc3OCVW+SEST3bSw0eRJGxlK+a23jelwzNlJxuQwjXDX QwHZuELUBr6BZpjvnLhH2FnVTBPs77XWnuc3ytnNluUB5NVQDQEN1ToYyxZP A1It8BmaPwBPx3ZPkmNvUxKnbf+YYB9ufbde69X/T2KShdWQLCwhydpa9Wl2 t7Qxly4YY6XPcS9jzE5FJ+6tOhnNyWhORnMymp+b0VTextqOo9muJXdvl9yo GBXnKHNlj+DGHgUu7JEVyurrCVfbbcixyn09im8LluyNCF2QCvcFRxoTtFea 7Si26R4hPTt3HOHfQ3Kqvm1hJ5tjfe9irwzNXineSLvs7UJK+Q6SNJF2LamA n6nD36Ln6XAZ2822YjjIO5o2JhOFq0IqDH1wztLspWK/YqVG2O6mmqCfj8H3 qd3f9Aiu7Jie5liKFwUuuTuWVrZFuvEreYOEoPd7e7ueuwJHvtfpkt3rtFEh 3bjVMUALpiL2P0YLbM8XSLhHq2S/WTGrp/Z00fSy62iOp7TijgDW0i4mFaqB LupqUiYc6PxJSj3SpTp0hCOm6nLH1BxH8aChUiXDkV5Un4/B931GeosBHwT2 FVnHpe5yBI6g31AkAwFe0CZaySZem0jokrilvLPrNejdVzHNyKuKZkIxaFLP WcLAXikHtkpotpuxuA/K6an9GjVZOMvXXFsRfFzqngDE0i4lFapxLepaUibv 3pNH9T1U6JnVG3wszTWVk7dCG8MhXeviwZlWet+eiR+eU7whZcm+JuY9G88o cK4X59EiQE5Jnz2U23MTd7qow01hb49Y8w+0hfGQunULXVxl4vYtYftNUqvz KEvbsMVRQ22GgZPyR8pLT63oLhyhzU/QWwR/YGE9Q/HKgXv3Vg+XJgqEgHwM LfOeIXpelfOf8Hve5PaAh/s86SdMbg+KT3/iT57d9qfs9pTdnrLbU3Z7ym5P iZopUTMlaqZEzWeSqJmy25PRnIzmZDQnozllt6fs9pTdnrLbU3Z7ym5P2e0p uz1lt6fs9pTdnrLbU3Z7ym5/sdlt+Foa5rMktdumhblsu5/LtlGH4Xmbwm7P SjPXdjdz3blmfMKabkO6KdPNIYgTOpsYzPa0fyujDKW3eEMQnHR7i4wZxVQS fQQ8FU3xui4HMLyU7/IJFf9CNkpv8pgIzV59Q2G1ztfJ6/kwrfmXfsym4zt+ Cy13Eljt4//0upHh16pyvYOAgCGWAX1eR52x3jr7U52nt0HGE+urm/R8IsGG o8u3nm100aaFo2uwDYKHOgz3Rhc9Kx1dXn90VdeMH13xFbr7AfdMmB4yEBRd gHy7OH9zURy39DsPQQPNuPM6+4R0x6Xcji/aqVo1juAqUziK3tVmvB0/UJ9s 1hLug6JA70biDbfCHRZPKxZvsnpwGU/12vF1epaTZQZoZWmrzpb/M1y1STjh O753uGpJdjDRt3Ac3wLHqnkdKy4crThLiIf3Kl29Rx9u4vAG3QQF2gZFdLIG rRolVBHNNvyfiyJ4CHoirVSWdx9v8YYrxTHDm/k/rekdti20vY7RN76OgXp8 Y8APSb6wnI4NNsCYXtpmY4OBLoYH57KBFXZNgRUG4ITAi8Hs+3OHtj9mZVK9 uSvIrwtEGDQNvIbLaGOhX6M/4zd9hUGCX5qwhfu/xUyH8xXV3kx9RxISCBjE 7xfBusHqJOews0rfIiHE6wWpOEcX7fU1eqv3T/RQSy5gYbv+wVj463/9qgYs nccbCuiiZgjOfcKQJBnzRurGf/nZSj0cs0oV/A+8uECllsEAAA== --+HaukhVL0H--