From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16846 invoked by alias); 20 Jan 2007 21:53:01 -0000 Received: (qmail 16835 invoked by uid 22791); 20 Jan 2007 21:53:00 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 20 Jan 2007 21:52:53 +0000 Received: from kahikatea.snap.net.nz (unknown [123.255.63.13]) by viper.snap.net.nz (Postfix) with ESMTP id 44BC03D83B0; Sun, 21 Jan 2007 10:52:46 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 4E1714F711; Sun, 21 Jan 2007 10:52:43 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17842.36650.58436.387233@kahikatea.snap.net.nz> Date: Sat, 20 Jan 2007 21:53:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Add value field to output of -var-create In-Reply-To: <20070120190903.GA22153@nevyn.them.org> References: <17818.12006.696879.216415@kahikatea.snap.net.nz> <20070105150747.GD24554@nevyn.them.org> <17839.14615.772612.987502@kahikatea.snap.net.nz> <20070120190903.GA22153@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.92.10 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00429.txt.bz2 > Thanks for doing this. I get some new failures - just three though. > > FAIL: gdb.mi/gdb701.exp: create fooPtr > FAIL: gdb.mi/gdb792.exp: create var for class A > FAIL: gdb.mi/gdb792.exp: create var for class C which has baseclass A Sorry, I forgot to include these (see below). > # Why does this have a FIXME? > setup_xfail *-*-* > mi_gdb_test "-var-update *" \ > ! "FIXME\\^done,changelist=\\\[\{name=\"psnp->ptrs.0.next.long_ptr\",in_scope=\pe_changed=\"false\"\}\\\]" \ > "update all vars psnp->next->long_ptr (and 1.long_ptr) changed" > clear_xfail *-*-* > > Typo, I think ("in_scope=\pe_changed")? OK. I could remove the setup_xfail and "FIXME" in the output string as this test passes for me. WDYT? -- Nick http://www.inet.net.nz/~nickrob 2007-01-21 Nick Roberts * gdb.mi/gdb701.exp, gdb.mi/gdb792.exp: Update tests for -var-create to include value field. Index: gdb.mi/gdb701.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/gdb701.exp,v retrieving revision 1.3 diff -c -p -r1.3 gdb701.exp *** gdb.mi/gdb701.exp 9 Jan 2007 17:59:13 -0000 1.3 --- gdb.mi/gdb701.exp 20 Jan 2007 21:50:16 -0000 *************** mi_run_to_main *** 50,58 **** # Step over "foo = 0" mi_next "step over \"foo = 0\"" ! mi_gdb_test "-var-create fooPtr * foo" \ ! "(&\".*\"\r\n)*\\^done,name=\"fooPtr\",numchild=\"3\",type=\"Foo \\*\"" \ ! "create fooPtr" mi_gdb_test "-var-list-children fooPtr" \ "(&\".*\"\r\n)*\\^done,numchild=\"3\",.*" \ --- 50,56 ---- # Step over "foo = 0" mi_next "step over \"foo = 0\"" ! mi_create_varobj fooPtr foo "create fooPtr" mi_gdb_test "-var-list-children fooPtr" \ "(&\".*\"\r\n)*\\^done,numchild=\"3\",.*" \ Index: gdb.mi/gdb792.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/gdb792.exp,v retrieving revision 1.6 diff -c -p -r1.6 gdb792.exp *** gdb.mi/gdb792.exp 9 Jan 2007 17:59:13 -0000 1.6 --- gdb.mi/gdb792.exp 20 Jan 2007 21:50:16 -0000 *************** if {[gdb_compile $srcdir/$subdir/$srcfil *** 50,56 **** mi_run_to_main mi_gdb_test "-var-create - * a" \ ! "(&\".*\"\r\n)*\\^done,name=\"var1\",numchild=\"3\",type=\"A\"" \ "create var for class A" mi_gdb_test "-var-list-children var1" \ --- 50,56 ---- mi_run_to_main mi_gdb_test "-var-create - * a" \ ! "(&\".*\"\r\n)*\\^done,name=\"var1\",numchild=\"3\",value=\".*\",type=\"A\"" \ "create var for class A" mi_gdb_test "-var-list-children var1" \ *************** mi_gdb_test "-var-list-children var1.pro *** 82,88 **** "list children of A.protected.b.private" mi_gdb_test "-var-create - * c" \ ! "(&\".*\"\r\n)*\\^done,name=\"var2\",numchild=\"3\",type=\"C\"" \ "create var for class C which has baseclass A" mi_gdb_test "-var-list-children var2" \ --- 82,88 ---- "list children of A.protected.b.private" mi_gdb_test "-var-create - * c" \ ! "(&\".*\"\r\n)*\\^done,name=\"var2\",numchild=\"3\",value=\".*\",type=\"C\"" \ "create var for class C which has baseclass A" mi_gdb_test "-var-list-children var2" \