From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26352 invoked by alias); 17 Jan 2007 08:12:34 -0000 Received: (qmail 26341 invoked by uid 22791); 17 Jan 2007 08:12:33 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 17 Jan 2007 08:12:26 +0000 Received: from kahikatea.snap.net.nz (unknown [123.255.62.204]) by viper.snap.net.nz (Postfix) with ESMTP id 083C83D8D9C; Wed, 17 Jan 2007 21:12:23 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id D43424F711; Wed, 17 Jan 2007 21:12:19 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17837.55904.753653.372700@kahikatea.snap.net.nz> Date: Wed, 17 Jan 2007 08:12:00 -0000 To: Daniel Jacobowitz Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: MI failures related to string printing In-Reply-To: <20070117060126.GB19331@nevyn.them.org> References: <200701121351.29310.vladimir@codesourcery.com> <20070116204407.784494F6C7@kahikatea.snap.net.nz> <17837.29931.145384.679968@kahikatea.snap.net.nz> <20070117060126.GB19331@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.92.10 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00383.txt.bz2 > > > Don't you think that a test that randomly fails depending on compiler > > > version and the address at which the binary happens to load is > > > completely useless. > > > > It has value because it doesn't fail for everyone. > > Sorry, Vladimir is correct. A test which fails intermittently (and > even if it's consistent for some people that doesn't change the fact > that this is a fundamentally intermittent problem) is not a good test. I'm not saying it is a good test, just that it's not completely useless. If someone who can see the fail fixes it, then clearly that's an improvement. > > By keeping the previous results and comparing them. I always get many > > fails when I run the testsuite. > > I am working on eliminating every single one of those failures; please > do not add more. I've just eliminated six fails in mi-basics.exp and mi2-basics.exp that had been around for years. No-one seemed that worried about them. I think we need a balanced approach in these matters. I certainly won't knowingly add any new failures. -- Nick http://www.inet.net.nz/~nickrob