From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6904 invoked by alias); 4 Jan 2007 23:22:32 -0000 Received: (qmail 6892 invoked by uid 22791); 4 Jan 2007 23:22:31 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Jan 2007 23:22:26 +0000 Received: from kahikatea.snap.net.nz (p202-124-120-54.snap.net.nz [202.124.120.54]) by viper.snap.net.nz (Postfix) with ESMTP id 045943D83B3; Fri, 5 Jan 2007 12:22:19 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 825ED4F6CD; Fri, 5 Jan 2007 12:22:17 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17821.35879.508258.356360@kahikatea.snap.net.nz> Date: Thu, 04 Jan 2007 23:22:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Add value field to output of -var-create In-Reply-To: References: <17818.12006.696879.216415@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.0.92.5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00160.txt.bz2 > I think this is a good change in general. However, the problem is that > a lot of tests hardcode the output from -var-create, and are broken with > this change. I think that instead of adding more hardcoding, we'd > need to replace all creation of varobjs with calls to mi_create_varobj. > Would you be willing to do that? It seems unfortunate to me that the output from -var-create gets tested so many times but Daniel has just said that mi_gdb_test should really should used even if you don't care about the result. Real tests for -var-create e.g in mi-var-cmd.exp need to be looked at more carefully (some test when -var-create fails) but, sure, mi_create_varobj could be used when you don't care about the result. -- Nick http://www.inet.net.nz/~nickrob