From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9246 invoked by alias); 1 Jan 2007 23:33:38 -0000 Received: (qmail 9236 invoked by uid 22791); 1 Jan 2007 23:33:37 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 01 Jan 2007 23:33:32 +0000 Received: from kahikatea.snap.net.nz (p202-124-124-112.snap.net.nz [202.124.124.112]) by viper.snap.net.nz (Postfix) with ESMTP id C96623D849C; Tue, 2 Jan 2007 12:33:27 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 0E3EA4F6EC; Tue, 2 Jan 2007 12:33:25 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17817.39491.798417.758434@kahikatea.snap.net.nz> Date: Mon, 01 Jan 2007 23:33:00 -0000 To: Daniel Jacobowitz Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [RFA] Cleanup mi_cmd_data_write_register_values In-Reply-To: <20070101030705.GA685@nevyn.them.org> References: <200701010145.l011j8FY027694@brahms.sibelius.xs4all.nl> <20070101030705.GA685@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.92.4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00035.txt.bz2 > > Index: ChangeLog > > from Mark Kettenis > > > > * mi/mi-main.c (mi_cmd_data_write_register_values): Use > > regcache_cooked_write_signed instead of > > deprecated_write_register_bytes. > > Patch looks OK. I'm almost glad this command is undocumented; this is > really all wrong as can be, since registers might not fit in the > LONGEST, and especially floating point registers have no business being > set from integer bit patterns. And it encourages sloppy frontends to > hard code register numbers. Yuck. Yes, previously it didn't work for me. Perhaps, however, we can get rid of this command if Vladimir commits his changes for "-var-list --registers". -- Nick http://www.inet.net.nz/~nickrob