From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28206 invoked by alias); 1 Jan 2007 09:18:57 -0000 Received: (qmail 28198 invoked by uid 22791); 1 Jan 2007 09:18:56 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 01 Jan 2007 09:18:50 +0000 Received: from farnswood.snap.net.nz (p202-124-124-28.snap.net.nz [202.124.124.28]) by viper.snap.net.nz (Postfix) with ESMTP id 0F2923D823B; Mon, 1 Jan 2007 22:18:47 +1300 (NZDT) Received: by farnswood.snap.net.nz (Postfix, from userid 500) id 75DDE627ED; Mon, 1 Jan 2007 09:16:37 +0000 (GMT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17816.53619.895367.798678@farnswood.snap.net.nz> Date: Mon, 01 Jan 2007 09:18:00 -0000 To: Daniel Jacobowitz Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH] MI: new timing command In-Reply-To: <20061231151527.GC16449@nevyn.them.org> References: <17814.10139.269708.848818@kahikatea.snap.net.nz> <17814.58031.865155.682869@kahikatea.snap.net.nz> <20061231042547.GA3236@nevyn.them.org> <17815.18190.987950.612053@kahikatea.snap.net.nz> <20061231054946.GA4873@nevyn.them.org> <17815.27092.497145.908734@kahikatea.snap.net.nz> <20061231151527.GC16449@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.50.58 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00017.txt.bz2 > > > I was wondering if we should make this a normal GDB setting, and use5C > > > "-gdb-set mi profiling on" to enable it. There's already a maint > > > setting to do the same thing for the CLI. > > > > The command "maint set profiling on" is relevant for both CLI and MI, > > whereas -enable-timings only works in MI. > > I wasn't talking about "maint set profiling on", but about "maint time > 1". That doesn't currently work in MI, but it could be made to work > and moved under the normal "set" hierarchy. Then we could use the same > setting for both CLI and MI. In that case you wouldn't have to invent > a new command that reimplements the "set" behavior; it could just be a > standard auto_boolean. I wasn't aware of "maint time 1" which does indeed seem very similar. In that case don't understand why you suggested "-gdb-set mi profiling on" and not "-gdb-set mi set time on". Anyway, in the case of MI, I'm not sure that you would want the user to be able to turn it on, so I'm not sure that the same setting is a good idea. Initially I would just use it manually from the command line. I don't currently have a front end that can consume the output but it clearly makes sense for the future. -- Nick http://www.inet.net.nz/~nickrob