From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19870 invoked by alias); 21 Dec 2006 22:42:35 -0000 Received: (qmail 19862 invoked by uid 22791); 21 Dec 2006 22:42:35 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Dec 2006 22:42:27 +0000 Received: from kahikatea.snap.net.nz (p202-124-120-96.snap.net.nz [202.124.120.96]) by viper.snap.net.nz (Postfix) with ESMTP id 5821D3DA0E7; Fri, 22 Dec 2006 11:44:01 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 74D87BE457; Fri, 22 Dec 2006 11:37:52 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17803.3261.229888.723300@kahikatea.snap.net.nz> Date: Thu, 21 Dec 2006 22:42:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Cleanup varobj children handling In-Reply-To: References: <200612082300.06688.ghost@cs.msu.su> X-Mailer: VM 7.19 under Emacs 22.0.92.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00296.txt.bz2 > > This patch changes varobj.c to use VEC for hodling children, thereby > > making three functions unnecessary. No regressions in MI tests. OK? > > Here's a revised patch, that additionally replaces 'vstack' code in varobj.c > with VEC(). All in all, some 130 lines of code gets wiped now. OK? I'm not familiar with vec.c yet - perhaps you and Daniel J discussed this issue privately - all I can say is that varobj. c has the comment: /* Every variable keeps a linked list of its children, described by the following structure. */ /* FIXME: Deprecated. All should use vlist instead */ Buy perhaps this is not relevant. -- Nick http://www.inet.net.nz/~nickrob