From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28814 invoked by alias); 22 Dec 2006 06:49:19 -0000 Received: (qmail 28804 invoked by uid 22791); 22 Dec 2006 06:49:18 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 22 Dec 2006 06:49:13 +0000 Received: from kahikatea.snap.net.nz (p202-124-120-122.snap.net.nz [202.124.120.122]) by viper.snap.net.nz (Postfix) with ESMTP id 86CAB3D8374; Fri, 22 Dec 2006 19:50:43 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 2CE3EBE457; Fri, 22 Dec 2006 19:44:31 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17803.32462.717366.776290@kahikatea.snap.net.nz> Date: Fri, 22 Dec 2006 06:49:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Cleanup varobj children handling In-Reply-To: <200612220918.15378.ghost@cs.msu.su> References: <200612082300.06688.ghost@cs.msu.su> <17803.3261.229888.723300@kahikatea.snap.net.nz> <200612220918.15378.ghost@cs.msu.su> X-Mailer: VM 7.19 under Emacs 22.0.92.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00302.txt.bz2 > > /* Every variable keeps a linked list of its children, described > > by the following structure. */ > > /* FIXME: Deprecated. All should use vlist instead */ > > > > Buy perhaps this is not relevant. > > The comment was written before vec.c was available, so it naturally > does not suggest vec.c. Before your change varobj.c had two (equivalent?) types of data structure: vstack and vlist. After your change varobj.c has two (equivalent?) types of data structure: VEC and vlist. Should VEC not also be used for vlist? -- Nick http://www.inet.net.nz/~nickrob