Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [doc] improve MI varobj introduction
Date: Wed, 20 Dec 2006 20:52:00 -0000	[thread overview]
Message-ID: <17801.41350.896824.320649@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200612201446.31705.vladimir@codesourcery.com>

Vladimir Prus writes:
 > On Wednesday 20 December 2006 01:24, Nick Roberts wrote:
 > > 
 > > I think it's a good idea to add this.
 > > 
 > >  > +For a leaf variable object it is possible to obtain its value as a
 > >  > +string, or set the value from a string.  String value can be also
 > >                                     ^^^^^^
 > > -var-assign var1 8  <- not a string
 > > ^done,value="8"
 > 
 > Actually, it is. The entire MI interface is based on strings. You cannot do:
 > 
 > 	int value;
 > 	mi_assign("V", value);

I don't follow.  AFAICS there is no function mi_assign and the manual is
about the interface not GDB internals.

 > You mean the first two paragraphs? Let me go though them:
 > 
 > 	- The basic idea behind variable objects is the creation 
 > 
 > This passage is just awkward, if not grammatically wrong.
 > 
 >   of a named object 
 >   -to represent a variable, an expression, a memory location or even a CPU
 >   -register.  For each object created, a set of operations is available for 
 >   -examining or changing its properties.
 > 
 > "Examining or changing its properties" is very vague. This is the first
 > paragraph of the introduction to MI varobjs, it should explicitly say what
 > user might want to use them for -- and abstract "property" is not explicit
 > enough.

I had no problem when I first read it but in any case it's Eli's call.

 >   -Furthermore, complex data types, such as C structures, are represented
 >   -in a tree format.  For instance, the @code{struct} type variable is the
 >   -root and the children will represent the struct members.  If a child
 >   -is itself of a complex type, it will also have children of its own.
 >
 > This is not so bad, but it fails to describe important properties of this
 > tree -- namely that only leafs carry any data.

That's why I suggested _adding_ your paragraph.

 > 	-Appropriate language differences are handled for C, C@t{++} and Java.
 >
 > This sentence is content-free. It's pretty obvious that a debugger cannot be
 > language-agnostic, and it's not clear that "Appropriate" differences are
 > and why would I care.

It tells me variable objects might not work for other languages.

 > > or that elaborating on the PRINT-VALUES option is a good idea. 
 > 
 > You mean the suggestion to use --all-values. I think it's important
 > information, and given that we have just one MI doc document, it's natural
 > to include this information. MI docs presently have too little content, not
 > too much.

I don't think the manual should recommend ways to use MI commands.  I guess
it could say that 

   the @samp{--all-values} option reduces the number of MI commands needed +on
   each program stop.

but that should be obvious anyway and we're starting to guess how someone is
using MI.

 > > Also expanding the introduction allows the removal of the summary of
 > > commands which just duplicates what comes after.
 > 
 > I'm not sure -- which summaries can be removed now?

The list just after:

 The following is the complete set of GDB/MI operations...

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2006-12-20 20:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-19  8:04 Vladimir Prus
2006-12-19 22:29 ` Nick Roberts
2006-12-20 11:47   ` Vladimir Prus
2006-12-20 20:52     ` Nick Roberts [this message]
2006-12-21  6:15       ` Vladimir Prus
2006-12-26 15:32         ` Daniel Jacobowitz
2006-12-26 15:52           ` Vladimir Prus
2006-12-26 22:38             ` Daniel Jacobowitz
2007-01-04 18:21               ` Vladimir Prus
2007-01-04 18:23               ` Vladimir Prus
2007-01-04 21:48                 ` Eli Zaretskii
2007-01-05  8:39                   ` Vladimir Prus
2007-01-05  9:26                     ` Eli Zaretskii
2007-01-08 14:50                       ` Vladimir Prus
2007-01-08 19:45                         ` Eli Zaretskii
2007-01-08 20:09                           ` Vladimir Prus
2007-01-09  4:18                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17801.41350.896824.320649@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox